You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/26 01:18:49 UTC

[GitHub] [apisix] moonming commented on a change in pull request #2311: fix: redirect is not correct

moonming commented on a change in pull request #2311:
URL: https://github.com/apache/apisix/pull/2311#discussion_r495361793



##########
File path: apisix/plugins/redirect.lua
##########
@@ -133,7 +134,12 @@ function _M.rewrite(conf, ctx)
         -- TODO： add test case
         -- PR: https://github.com/apache/apisix/pull/1958
         uri = "https://$host$request_uri"
-        ret_code = 301
+        local method_name = ngx.req.get_method()
+        if method_name == "GET" or method_name == "HEAD" then
+            ret_code = 301

Review comment:
       need add test cases for these codes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org