You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/11/29 16:45:50 UTC

[GitHub] [ozone] adoroszlai opened a new pull request, #4012: HDDS-7540. Let reusable workflow inherit secrets

adoroszlai opened a new pull request, #4012:
URL: https://github.com/apache/ozone/pull/4012

   ## What changes were proposed in this pull request?
   
   Minor addendum for #4004: the reusable workflow does not get the caller's secrets by default, so the _coverage_ check is running into error.
   
   ```
   SONAR_TOKEN environment variable should be set
   ```
   
   https://github.com/apache/ozone/actions/runs/3574181477/jobs/6010427884#step:8:19
   
   The _coverage_ check run only in Apache repo for `push` events, so it was not flagged in my fork, nor the PR.
   
   Reference:
   https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idsecretsinherit
   
   https://issues.apache.org/jira/browse/HDDS-7540
   
   ## How was this patch tested?
   
   It will be tested when the PR is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #4012: HDDS-7540. Let reusable workflow inherit secrets

Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #4012:
URL: https://github.com/apache/ozone/pull/4012


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] kerneltime commented on pull request #4012: HDDS-7540. Let reusable workflow inherit secrets

Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #4012:
URL: https://github.com/apache/ozone/pull/4012#issuecomment-1333320458

   I was looking at the commit log and noticed the failure. Thank you for the fix!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #4012: HDDS-7540. Let reusable workflow inherit secrets

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #4012:
URL: https://github.com/apache/ozone/pull/4012#issuecomment-1333513480

   Thanks @kerneltime for the review.
   
   > Should we add coverage to PRs?
   
   It wouldn't have helped here, because the part that requires the token (upload to Sonar) is not applicable to PRs.
   
   We can discuss possible ways to utilize coverage data for PRs later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] kerneltime commented on pull request #4012: HDDS-7540. Let reusable workflow inherit secrets

Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #4012:
URL: https://github.com/apache/ozone/pull/4012#issuecomment-1333320819

   Should we add coverage to PRs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org