You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Rui Sun <ru...@intel.com> on 2013/12/29 14:47:08 UTC

Review Request 16504: HIVE-6120 Add GroupBy optimization to eliminate un-needed partial distinct aggregations

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16504/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-6120
    https://issues.apache.org/jira/browse/HIVE-6120


Repository: hive


Description
-------

Add GroupBy optimization to eliminate un-needed partial distinct aggregations.


Diffs
-----

  /trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapGroupByDistinctAggrOptimizer.java PRE-CREATION 
  /trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 1553458 
  /trunk/ql/src/test/results/clientpositive/auto_join18.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/auto_join18_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/auto_join32.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/count.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby2_map.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby2_map_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby2_map_skew.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby3_map.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby3_map_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby3_map_skew.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_cube1.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_distinct_samekey.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_map_ppr.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_map_ppr_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_multi_insert_common_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_position.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_rollup1.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_sort_11.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/join18.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/join18_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/limit_pushdown.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/metadataonly1.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/multi_insert_gby3.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/multi_insert_lateral_view.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/nullgroup4.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/udf_count.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/vectorization_limit.q.out 1553458 

Diff: https://reviews.apache.org/r/16504/diff/


Testing
-------

clientpositive


Thanks,

Rui Sun


Re: Review Request 16504: HIVE-6120 Add GroupBy optimization to eliminate un-needed partial distinct aggregations

Posted by Rui Sun <ru...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16504/
-----------------------------------------------------------

(Updated Dec. 30, 2013, 7:15 a.m.)


Review request for hive.


Changes
-------

Fix test failures.


Bugs: HIVE-6120
    https://issues.apache.org/jira/browse/HIVE-6120


Repository: hive


Description
-------

Add GroupBy optimization to eliminate un-needed partial distinct aggregations.


Diffs (updated)
-----

  /trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapGroupByDistinctAggrOptimizer.java PRE-CREATION 
  /trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 1553458 
  /trunk/ql/src/test/results/clientpositive/auto_join18.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/auto_join18_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/auto_join32.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/count.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby2_map.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby2_map_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby2_map_skew.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby3_map.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby3_map_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby3_map_skew.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_cube1.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_distinct_samekey.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_map_ppr.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_map_ppr_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_multi_insert_common_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_position.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_rollup1.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_sort_11.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/groupby_sort_8.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/join18.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/join18_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/limit_pushdown.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/metadataonly1.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/multi_insert_gby3.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/multi_insert_lateral_view.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/nullgroup4.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/nullgroup4_multi_distinct.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/udf_count.q.out 1553458 
  /trunk/ql/src/test/results/clientpositive/vectorization_limit.q.out 1553458 
  /trunk/ql/src/test/results/compiler/plan/groupby2.q.xml 1553458 
  /trunk/ql/src/test/results/compiler/plan/groupby3.q.xml 1553458 

Diff: https://reviews.apache.org/r/16504/diff/


Testing
-------

clientpositive


Thanks,

Rui Sun