You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/29 11:19:04 UTC

[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #892: Make readline/cle work without CONFIG_FILE_STREAM

Ouss4 commented on a change in pull request #892:
URL: https://github.com/apache/incubator-nuttx-apps/pull/892#discussion_r758265673



##########
File path: include/system/readline.h
##########
@@ -171,6 +171,16 @@ FAR const struct extmatch_vtable_s *
  *
  ****************************************************************************/
 
+ssize_t readline_fd(FAR char *buf, int buflen, int infd, int outfd);
+
+/****************************************************************************
+ * Name: readline
+ *
+ *   readline() is same as readline_fd() but accept the file stream instead
+ *   of file handle.

Review comment:
       ```suggestion
    *   readline() is similar to readline_fd() but accepts a file stream instead
    *   of a file descriptor.
   ```
   nit:  Regarding description.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org