You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/27 01:56:12 UTC

[GitHub] [airflow] yunstanford commented on a change in pull request #5669: [AIRFLOW-5053] Add support for configuring under-the-hood csv writer for handling special char, like double quote from json columns

yunstanford commented on a change in pull request #5669: [AIRFLOW-5053] Add support for configuring under-the-hood csv writer for handling special char, like double quote from json columns
URL: https://github.com/apache/airflow/pull/5669#discussion_r307948971
 
 

 ##########
 File path: tests/operators/test_operators.py
 ##########
 @@ -470,6 +470,57 @@ def test_mysql_to_hive_type_conversion(self, mock_load_file):
             with m.get_conn() as c:
                 c.execute("DROP TABLE IF EXISTS {}".format(mysql_table))
 
+    @unittest.skipUnless('mysql' in configuration.conf.get('core', 'sql_alchemy_conn'),
+                         "This is a MySQL test")
+    def test_mysql_to_hive_verify_csv_special_char(self):
 
 Review comment:
   unit test failed without the fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services