You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/31 20:51:22 UTC
[GitHub] [arrow] alamb opened a new pull request #8086: Switch from Box --> SchemaRef (Arc) to be consistent with the rest of Arrow
alamb opened a new pull request #8086:
URL: https://github.com/apache/arrow/pull/8086
This PR proposes using `SchemaRef` (which is an `Arc<Schema>`) instead of `Box<Schema> `inside Datafusion to be consistent with the rest of the arrow implementation, avoid so many copies, and make the code simpler.
A pretty good example of the simplification is:
*before*:
```
projected_schema: Box::new(csv.schema().as_ref().to_owned()),
```
*after*:
```
projected_schema: csv.schema().clone()),
```
This code is not only clearer to understand in my opinion, it is also likely faster (it is a clone of an `Arc` (and an increment of a refcount) rather than a clone of the actual `Schema` itself)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8086: ARROW-9821: Switch from Box --> SchemaRef (Arc) to be consistent with the rest of Arrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8086:
URL: https://github.com/apache/arrow/pull/8086#issuecomment-684039592
https://issues.apache.org/jira/browse/ARROW-9821
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8086: ARROW-9899: [Rust] [DataFusion] Switch from Box --> SchemaRef (Arc) to be consistent with the rest of Arrow
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8086:
URL: https://github.com/apache/arrow/pull/8086#issuecomment-686403331
@andygrove -- rebased
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on pull request #8086: ARROW-9899: [Rust] [DataFusion] Switch from Box --> SchemaRef (Arc) to be consistent with the rest of Arrow
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8086:
URL: https://github.com/apache/arrow/pull/8086#issuecomment-686096068
@alamb This one needs another rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8086: ARROW-9899: [Rust] [DataFusion] Switch from Box --> SchemaRef (Arc) to be consistent with the rest of Arrow
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8086:
URL: https://github.com/apache/arrow/pull/8086#issuecomment-685788611
https://issues.apache.org/jira/browse/ARROW-9899
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove closed pull request #8086: ARROW-9899: [Rust] [DataFusion] Switch from Box --> SchemaRef (Arc) to be consistent with the rest of Arrow
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8086:
URL: https://github.com/apache/arrow/pull/8086
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #8086: ARROW-9899: [Rust] [DataFusion] Switch from Box --> SchemaRef (Arc) to be consistent with the rest of Arrow
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #8086:
URL: https://github.com/apache/arrow/pull/8086#issuecomment-685784996
Rebased against master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb edited a comment on pull request #8086: ARROW-9899: [Rust] [DataFusion] Switch from Box --> SchemaRef (Arc) to be consistent with the rest of Arrow
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #8086:
URL: https://github.com/apache/arrow/pull/8086#issuecomment-685784996
Rebased against master and changed JIRA reference to https://issues.apache.org/jira/browse/ARROW-9899 so that we have one JIRA issue per PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org