[jira] Closed: (MYFACES-264) Cast to Number instead of Integer for component properties which expects a int value

["Mathias Broekelmann (JIRA)" <my...@incubator.apache.org>]

In-Reply-To: <73...@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

     [ http://issues.apache.org/jira/browse/MYFACES-264?page=3Dall ]
    =20
Mathias Broekelmann closed MYFACES-264:
---------------------------------------

    Resolution: Fixed

patch for HtmlPanelGrid applied

> Cast to Number instead of Integer for component properties which expects =
a int value

> -------------------------------------------------------------------------=
------------
>
>          Key: MYFACES-264
>          URL: http://issues.apache.org/jira/browse/MYFACES-264
>      Project: MyFaces
>         Type: Sub-task
>     Versions: Nightly Build
>     Reporter: Mathias Broekelmann
>     Assignee: Grant Smith
>  Attachments: FixedNumberCastForIntegerAttributes.diff
>
> The component properties which expect integers cast the result of the val=
uebindings to Integer. This prevents the use of el expressions like #{2} si=
nce a integer literal is evalutated to a Long value. I know the RI also cas=
t to Integer but I have not found it in the spec that this is a requirement=
. IMO that wouldn=C2=B4t make sense either.
> I would suggest to cast to Number and call Number.intValue() which handle=
s the conversion to int.
> I have found the problem in the following components:
> HtmlDataScroller.getFastStep()
> HtmlDataScroller.getPaginatorMaxPages()
> HtmlPopup.getDisplayAtDistanceX()
> HtmlPopup.getDisplayAtDistanceY()
> SelectOneCountry.getMaxLength()
> HtmlPanelTabbedPane.getSelectedIndex()
> HtmlDataTable.getBorder()
> HtmlInputSecret.getMaxlength()
> HtmlInputSecret.getSize()
> HtmlInputText.getMaxlength()
> HtmlInputText.getSize()
> HtmlInputTextarea.getCols()
> HtmlInputTextarea.getRows()
> HtmlPanelGrid.getBorder()
> HtmlPanelGrid.getColumns()
> HtmlSelectManyCheckbox.getBorder()
> HtmlSelectManyListbox.getSize()
> HtmlSelectOneListbox.getSize()
> HtmlSelectOneRadio.getBorder()

--=20
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira