You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/25 08:27:17 UTC
[GitHub] [doris] adonis0147 commented on a diff in pull request #13647: [enhancement](chore) Enhance build script compatibility
adonis0147 commented on code in PR #13647:
URL: https://github.com/apache/doris/pull/13647#discussion_r1004163133
##########
build.sh:
##########
@@ -451,7 +452,11 @@ if [[ "${FE_MODULES}" != '' ]]; then
if [[ "${CLEAN}" -eq 1 ]]; then
clean_fe
fi
- "${MVN_CMD}" package -pl ${FE_MODULES:+${FE_MODULES}} -DskipTests
+ MVN_PARAMS="-DskipTests"
+ if [[ "$(uname -s)" = 'Darwin' ]]; then
+ MVN_PARAMS="${MVN_PARAMS} -Dos.arch=x86_64"
+ fi
Review Comment:
It seems that we don't need this option `-Dos.arch=x86_64` anymore. See #13571.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org