You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/16 10:40:50 UTC
[GitHub] [shardingsphere] yanickxia opened a new pull request #7486: Fix shadow value in literal expression
yanickxia opened a new pull request #7486:
URL: https://github.com/apache/shardingsphere/pull/7486
Fixes #7280.
Changes proposed in this pull request:
- fix shadow value in literal expression
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #7486: Fix shadow value in literal expression
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7486:
URL: https://github.com/apache/shardingsphere/pull/7486#issuecomment-694618588
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7486?src=pr&el=h1) Report
> Merging [#7486](https://codecov.io/gh/apache/shardingsphere/pull/7486?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/de6a0bc1a0ffc1fe34bf4872b7b0b7ac217481a3?el=desc) will **increase** coverage by `0.20%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/7486?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7486 +/- ##
============================================
+ Coverage 75.29% 75.50% +0.20%
- Complexity 481 482 +1
============================================
Files 1362 1374 +12
Lines 22141 22135 -6
Branches 3920 3922 +2
============================================
+ Hits 16672 16713 +41
+ Misses 4417 4371 -46
+ Partials 1052 1051 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7486?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...udge/impl/PreparedShadowDataSourceJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1yb3V0ZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhZG93L3JvdXRlL2VuZ2luZS9qdWRnZS9pbXBsL1ByZXBhcmVkU2hhZG93RGF0YVNvdXJjZUp1ZGdlRW5naW5lLmphdmE=) | `50.00% <25.00%> (+35.71%)` | `0.00 <0.00> (ø)` | |
| [...lidator/impl/ShardingDeleteStatementValidator.java](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS92YWxpZGF0b3IvaW1wbC9TaGFyZGluZ0RlbGV0ZVN0YXRlbWVudFZhbGlkYXRvci5qYXZh) | `33.33% <0.00%> (-4.17%)` | `0.00% <0.00%> (ø%)` | |
| [...rypt/rewrite/condition/EncryptConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS9jb25kaXRpb24vRW5jcnlwdENvbmRpdGlvbkVuZ2luZS5qYXZh) | `59.25% <0.00%> (-0.75%)` | `0.00% <0.00%> (ø%)` | |
| [...ion/engine/WhereClauseShardingConditionEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL1doZXJlQ2xhdXNlU2hhcmRpbmdDb25kaXRpb25FbmdpbmUuamF2YQ==) | `56.25% <0.00%> (-0.46%)` | `0.00% <0.00%> (ø%)` | |
| [...tor/impl/EncryptPredicateColumnTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9FbmNyeXB0UHJlZGljYXRlQ29sdW1uVG9rZW5HZW5lcmF0b3IuamF2YQ==) | `87.87% <0.00%> (-0.36%)` | `1.00% <0.00%> (ø%)` | |
| [.../postgresql/visitor/impl/PostgreSQLDMLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1wb3N0Z3Jlc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Bvc3RncmVzcWwvdmlzaXRvci9pbXBsL1Bvc3RncmVTUUxETUxWaXNpdG9yLmphdmE=) | `81.45% <0.00%> (-0.19%)` | `0.00% <0.00%> (ø%)` | |
| [...sql/parser/sqlserver/visitor/SQLServerVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWxzZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3Fsc2VydmVyL3Zpc2l0b3IvU1FMU2VydmVyVmlzaXRvci5qYXZh) | `71.95% <0.00%> (-0.12%)` | `1.00% <0.00%> (ø%)` | |
| [...phere/sql/parser/oracle/visitor/OracleVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3IvT3JhY2xlVmlzaXRvci5qYXZh) | `75.52% <0.00%> (-0.11%)` | `1.00% <0.00%> (ø%)` | |
| [...sql/parser/sql92/visitor/impl/SQL92DMLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL2ltcGwvU1FMOTJETUxWaXNpdG9yLmphdmE=) | `82.53% <0.00%> (-0.10%)` | `0.00% <0.00%> (ø%)` | |
| [...gsphere/sql/parser/sql92/visitor/SQL92Visitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL1NRTDkyVmlzaXRvci5qYXZh) | `78.15% <0.00%> (-0.10%)` | `1.00% <0.00%> (ø%)` | |
| ... and [55 more](https://codecov.io/gh/apache/shardingsphere/pull/7486/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7486?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7486?src=pr&el=footer). Last update [de6a0bc...b4c53b1](https://codecov.io/gh/apache/shardingsphere/pull/7486?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yanyzy commented on pull request #7486: Fix shadow value in literal expression
Posted by GitBox <gi...@apache.org>.
yanyzy commented on pull request #7486:
URL: https://github.com/apache/shardingsphere/pull/7486#issuecomment-694611760
Could you add some unit tests in ShadowPreparedStatementTest?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yanyzy merged pull request #7486: Fix shadow value in literal expression
Posted by GitBox <gi...@apache.org>.
yanyzy merged pull request #7486:
URL: https://github.com/apache/shardingsphere/pull/7486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yanyzy closed pull request #7486: Fix shadow value in literal expression
Posted by GitBox <gi...@apache.org>.
yanyzy closed pull request #7486:
URL: https://github.com/apache/shardingsphere/pull/7486
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7486: Fix shadow value in literal expression
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7486:
URL: https://github.com/apache/shardingsphere/pull/7486#issuecomment-694619714
## Pull Request Test Coverage Report for [Build 14874](https://coveralls.io/builds/33551617)
* **1** of **4** **(25.0%)** changed or added relevant lines in **1** file are covered.
* **233** unchanged lines in **32** files lost coverage.
* Overall coverage increased (+**0.04%**) to **35.087%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-route/src/main/java/org/apache/shardingsphere/shadow/route/engine/judge/impl/PreparedShadowDataSourceJudgeEngine.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-features%2Fshardingsphere-shadow%2Fshardingsphere-shadow-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Froute%2Fengine%2Fjudge%2Fimpl%2FPreparedShadowDataSourceJudgeEngine.java#L105) | 1 | 4 | 25.0%
<!-- | **Total:** | **1** | **4** | **25.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-rewrite/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptPredicateColumnTokenGenerator.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FEncryptPredicateColumnTokenGenerator.java#L75) | 1 | 96.97% |
| [shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-route/src/main/java/org/apache/shardingsphere/shadow/route/engine/judge/impl/PreparedShadowDataSourceJudgeEngine.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-features%2Fshardingsphere-shadow%2Fshardingsphere-shadow-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Froute%2Fengine%2Fjudge%2Fimpl%2FPreparedShadowDataSourceJudgeEngine.java#L81) | 1 | 73.81% |
| [shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/mysql/command/generic/MySQLUnsupportedCommandExecutor.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-frontend%2Fshardingsphere-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Ffrontend%2Fmysql%2Fcommand%2Fgeneric%2FMySQLUnsupportedCommandExecutor.java#L38) | 1 | 0% |
| [shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/proxy/frontend/mysql/command/query/text/query/MySQLComQueryPacketExecutor.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-frontend%2Fshardingsphere-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Ffrontend%2Fmysql%2Fcommand%2Fquery%2Ftext%2Fquery%2FMySQLComQueryPacketExecutor.java#L125) | 1 | 79.41% |
| [shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/spi/ScalingEntryLoader.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fcore%2Fspi%2FScalingEntryLoader.java#L51) | 1 | 88.89% |
| [shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/utils/ThreadUtil.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fcore%2Futils%2FThreadUtil.java#L37) | 1 | 75.0% |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/inline/InlineShardingAlgorithm.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Falgorithm%2Fsharding%2Finline%2FInlineShardingAlgorithm.java#L77) | 2 | 88.89% |
| [shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/java/org/apache/shardingsphere/proxy/Bootstrap.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-bootstrap%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2FBootstrap.java#L46) | 2 | 0% |
| [shardingsphere-scaling/shardingsphere-scaling-mysql/src/main/java/org/apache/shardingsphere/scaling/mysql/MySQLPositionManager.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fmysql%2FMySQLPositionManager.java#L33) | 2 | 93.55% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/statement/dml/DeleteStatement.java](https://coveralls.io/builds/33551617/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fcommon%2Fstatement%2Fdml%2FDeleteStatement.java#L33) | 2 | 0% |
<!-- | **Total:** | **233** | | -->
| Totals | [](https://coveralls.io/builds/33551617) |
| :-- | --: |
| Change from base [Build 14830](https://coveralls.io/builds/33498810): | 0.04% |
| Covered Lines: | 36577 |
| Relevant Lines: | 104247 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org