You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Dan Haywood (JIRA)" <ji...@apache.org> on 2010/12/15 00:02:01 UTC

[jira] Created: (ISIS-19) i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)

i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)
-------------------------------------------------------------------------------------

                 Key: ISIS-19
                 URL: https://issues.apache.org/jira/browse/ISIS-19
             Project: Isis
          Issue Type: Bug
          Components: Viewer: BDD
            Reporter: Dan Haywood
            Assignee: Dan Haywood
             Fix For: 0.1.0-incubating


Raised on Sabine's behalf.

Sabine has informally provided a patch for one of the defects impacted by this (DateParser), but this needs to be submitted formally as a patch on via this ticket in order to provide IP clearance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ISIS-19) i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)

Posted by "Sabine Winkler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ISIS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971586#action_12971586 ] 

Sabine Winkler commented on ISIS-19:
------------------------------------

While the DateParser is using the local timezone the org.apache.isis.applib.value.Date is always based on UTC timezone. So when testing a currently parsed date from another timezone (which might be "equal" in the meaning og the same date) the time differs and date/time based tests will fail. A patch was provided informally to Dan and is attached here.

> i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)
> -------------------------------------------------------------------------------------
>
>                 Key: ISIS-19
>                 URL: https://issues.apache.org/jira/browse/ISIS-19
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: BDD
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 0.1.0-incubating
>
>
> Raised on Sabine's behalf.
> Sabine has informally provided a patch for one of the defects impacted by this (DateParser), but this needs to be submitted formally as a patch on via this ticket in order to provide IP clearance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ISIS-19) i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)

Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ISIS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood resolved ISIS-19.
-----------------------------

    Resolution: Fixed

waiting for Sabine to re-test, but now works for me.

> i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)
> -------------------------------------------------------------------------------------
>
>                 Key: ISIS-19
>                 URL: https://issues.apache.org/jira/browse/ISIS-19
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: BDD
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 0.1.0-incubating
>
>         Attachments: DateParser.java
>
>
> Raised on Sabine's behalf.
> Sabine has informally provided a patch for one of the defects impacted by this (DateParser), but this needs to be submitted formally as a patch on via this ticket in order to provide IP clearance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (ISIS-19) i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)

Posted by "Dan Haywood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ISIS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dan Haywood closed ISIS-19.
---------------------------


In which case, let's close it.  Thanks for re-testing this, Sabine.

> i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)
> -------------------------------------------------------------------------------------
>
>                 Key: ISIS-19
>                 URL: https://issues.apache.org/jira/browse/ISIS-19
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: BDD
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 0.1.0-incubating
>
>         Attachments: DateParser.java
>
>
> Raised on Sabine's behalf.
> Sabine has informally provided a patch for one of the defects impacted by this (DateParser), but this needs to be submitted formally as a patch on via this ticket in order to provide IP clearance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ISIS-19) i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)

Posted by "Sabine Winkler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ISIS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972083#action_12972083 ] 

Sabine Winkler commented on ISIS-19:
------------------------------------

Re-test successful - no test fails in prototpye/viewer-bdd under 'german' locale.

> i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)
> -------------------------------------------------------------------------------------
>
>                 Key: ISIS-19
>                 URL: https://issues.apache.org/jira/browse/ISIS-19
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: BDD
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 0.1.0-incubating
>
>         Attachments: DateParser.java
>
>
> Raised on Sabine's behalf.
> Sabine has informally provided a patch for one of the defects impacted by this (DateParser), but this needs to be submitted formally as a patch on via this ticket in order to provide IP clearance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ISIS-19) i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)

Posted by "Sabine Winkler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ISIS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sabine Winkler updated ISIS-19:
-------------------------------

    Attachment: DateParser.java

org.apache.isis.viewer.bdd.common.parsers.DateParser - patch, working internal on timezone UTC

> i18n issue with date parsing for BDD viewer (new CheckList, VerifyRows functionality)
> -------------------------------------------------------------------------------------
>
>                 Key: ISIS-19
>                 URL: https://issues.apache.org/jira/browse/ISIS-19
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: BDD
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>             Fix For: 0.1.0-incubating
>
>         Attachments: DateParser.java
>
>
> Raised on Sabine's behalf.
> Sabine has informally provided a patch for one of the defects impacted by this (DateParser), but this needs to be submitted formally as a patch on via this ticket in order to provide IP clearance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.