[GitHub] [hbase-operator-tools] wchevreuil commented on a change in pull request #3: Hbase 22567

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #3: Hbase 22567
URL: https://github.com/apache/hbase-operator-tools/pull/3#discussion_r299160809
 
 

 ##########
 File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
 ##########
 @@ -164,6 +171,86 @@ int setRegionState(String region, RegionState.State newState)
     return EXIT_FAILURE;
   }
 
+  int addMissingRegionsInMeta(String... tableNames) throws  IOException {
 
 Review comment:
   @joshelser @busbey , Sorry for the delay. I think these are all good ideas. Had pushed a commit where I'm trying to implement the plumbing/porcelain approach within 3 methods: _addMissingRegionsInMeta_, _addMissingRegionsInMetaForTables_ and _reportTablesWithMissingRegionsInMeta_. The original porcelain method is now _addMissingRegionsInMetaForTables_. It combines _addMissingRegionsInMeta_ and _reportTablesWithMissingRegionsInMeta_ calls to add regions back in meta. _reportTablesWithMissingRegionsInMeta_ can is also exposed as a CLI method, as a mean to provide a reporting only command for operators. Some additional UTs are still pending, but an initial manual testing on a broke cluster did look promising. Let me know what you guys think about these, while I will add more UTs for those.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services