[GitHub] [daffodil] tuxji commented on a diff in pull request #975: Warn when annotations placed on group definition

["tuxji (via GitHub)" <gi...@apache.org>]

tuxji commented on code in PR #975:
URL: https://github.com/apache/daffodil/pull/975#discussion_r1122508817


##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/GroupDef.scala:
##########
@@ -131,6 +133,15 @@ sealed abstract class GlobalGroupDef(
     }
   }
 
+  private def checkForGroupDefAnnotations(): Unit = {
+    // Ensure that the group definition itself does not have any annotations.
+    // Annotations should only be on group references or children of the group
+    // definition
+    val found = defXML.child.map(_.label).contains("annotation")

Review Comment:
   Agreed.  Will expect a new commit to check appinfo and fix formatting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org