You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/07/25 05:16:27 UTC

[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #5880: [Improvement][API] Page paging query API result data structure optimization

github-actions[bot] commented on issue #5880:
URL: https://github.com/apache/dolphinscheduler/issues/5880#issuecomment-886148484


   **Describe the question**
   Activity:
   Open source software supply chain lighting plan-summer 2021
   
   Description of Requirement:
   
   The current Page pagination query results need to be converted. The data structure is inconsistent with the returned results and the structure provided by Page pagination. Refactor PageInfo to improve the code specification and interface consistency.
   
   Technology involved: Java/VUE
   
   Phenomenon:
   
   In the paging query, the service layer paging query returns the result PageInfo, and another layer of data structure transformation is done in the Controller layer (such as: ProjectController.queryProjectListPaging()). The optimization here is to reconstruct the PageInfo data structure and remove the redundant transformation of the Controller layer. , Improve code specification and interface consistency
   
   requires attention:
   
   At present, there are also some API paging interfaces that do not perform result structure conversion at the Controller layer, and they need to be compatible here (such as: ProcessDefinitionController.queryProcessDefinitionVersions())
   
   ---
   活动:
   开源软件供应链点亮计划-暑期2021
   
   需求描述:
   
   当前Page分页查询结果需转化数据结构在返回结果和Page分页对外提供结构不一致,重构PageInfo,提高代码规范和接口一致性
   
   涉及技术:Java/VUE
   
   现象:
   
   在分页查询中,Service层分页查询返回结果PageInfo,在Controller层又做了一层数据结构转化(如:ProjectController.queryProjectListPaging()), 此处优化是重构PageInfo数据结构,去除Controller层多余的转化,提高代码规范和接口一致性
   
   需要注意:
   
   目前也存在部分API分页接口没有在Controller层进行结果结构转换,此处需做兼容出来(如:ProcessDefinitionController.queryProcessDefinitionVersions())
   
   
   **Which version of DolphinScheduler:**
    -[dev]
   
   
   This task is already assigned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org