You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/21 09:55:34 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on pull request #4817: [Fix-4816][API] The API calls the workflow instance query interface and queries all the data when the time parameter is wrong
codecov-io edited a comment on pull request #4817:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4817#issuecomment-782200637
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817?src=pr&el=h1) Report
> Merging [#4817](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817?src=pr&el=desc) (3a3b660) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/ce007813fb069d46a56863340d8d580fecddb007?el=desc) (ce00781) will **decrease** coverage by `0.22%`.
> The diff coverage is `97.05%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #4817 +/- ##
============================================
- Coverage 45.46% 45.24% -0.23%
+ Complexity 3416 3397 -19
============================================
Files 538 539 +1
Lines 23047 23057 +10
Branches 2686 2686
============================================
- Hits 10478 10431 -47
- Misses 11632 11695 +63
+ Partials 937 931 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/api/service/impl/ProcessInstanceServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9Qcm9jZXNzSW5zdGFuY2VTZXJ2aWNlSW1wbC5qYXZh) | `75.00% <85.71%> (+0.77%)` | `37.00 <0.00> (+1.00)` | |
| [...ache/dolphinscheduler/api/service/BaseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQmFzZVNlcnZpY2UuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...hinscheduler/api/service/impl/BaseServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9CYXNlU2VydmljZUltcGwuamF2YQ==) | `94.28% <100.00%> (+1.69%)` | `18.00 <3.00> (+3.00)` | |
| [...uler/api/service/impl/DataAnalysisServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9EYXRhQW5hbHlzaXNTZXJ2aWNlSW1wbC5qYXZh) | `98.87% <100.00%> (-0.04%)` | `29.00 <2.00> (-1.00)` | |
| [...uler/api/service/impl/TaskInstanceServiceImpl.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvaW1wbC9UYXNrSW5zdGFuY2VTZXJ2aWNlSW1wbC5qYXZh) | `98.24% <100.00%> (-0.15%)` | `12.00 <0.00> (-3.00)` | |
| [...he/dolphinscheduler/common/enums/SqoopJobType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL1Nxb29wSm9iVHlwZS5qYXZh) | `0.00% <0.00%> (-88.89%)` | `0.00% <0.00%> (-3.00%)` | |
| [.../server/master/runner/DependentTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvRGVwZW5kZW50VGFza0V4ZWNUaHJlYWQuamF2YQ==) | `51.57% <0.00%> (-16.85%)` | `10.00% <0.00%> (-5.00%)` | |
| [...ver/master/consumer/TaskPriorityQueueConsumer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9jb25zdW1lci9UYXNrUHJpb3JpdHlRdWV1ZUNvbnN1bWVyLmphdmE=) | `43.33% <0.00%> (-10.00%)` | `16.00% <0.00%> (-4.00%)` | |
| [...olphinscheduler/server/utils/DependentExecute.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL0RlcGVuZGVudEV4ZWN1dGUuamF2YQ==) | `61.84% <0.00%> (-9.22%)` | `17.00% <0.00%> (-4.00%)` | |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | `3.00% <0.00%> (-1.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817?src=pr&el=footer). Last update [ce00781...3a3b660](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/4817?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org