[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #17853: [fxi][doc] Rewrite the steps of docker-deploy

[GitBox <gi...@apache.org>]

Demogorgon314 commented on code in PR #17853:
URL: https://github.com/apache/pulsar/pull/17853#discussion_r981866128


##########
site2/docs/deploy-docker.md:
##########
@@ -3,50 +3,127 @@ id: deploy-docker
 title: Deploy a cluster on Docker
 sidebar_label: "Docker"
 ---
-
-To deploy a Pulsar cluster on Docker, complete the following steps:
-1. Deploy a ZooKeeper cluster (optional)
-2. Initialize cluster metadata
-3. Deploy a BookKeeper cluster
-4. Deploy one or more Pulsar brokers
+## Deploy a cluster on Docker
+To deploy a Pulsar cluster on Docker, you need to complete the next steps:
+1. pull the pulsar docker image
+2. create the zookeeper, bookie, broker container by the image
+3. modify the broker.conf and bookkeeper.conf
+4. create a network, and make the container connects to it.
+5. start the zookeeper, and then init the cluster metadata
+6. start the broker and bookie
 
 ## Prepare
+To run Pulsar on Docker, you need to create a container for each Pulsar component: ZooKeeper, BookKeeper and broker. You can pull the images of ZooKeeper and BookKeeper separately on Docker Hub, and pull a Pulsar image for the broker. You can also pull only one Pulsar image and create three containers with this image. This tutorial takes the second option as an example.
 
-To run Pulsar on Docker, you need to create a container for each Pulsar component: ZooKeeper, BookKeeper and broker. You can pull the images of ZooKeeper and BookKeeper separately on [Docker Hub](https://hub.docker.com/), and pull a [Pulsar image](https://hub.docker.com/r/apachepulsar/pulsar-all/tags) for the broker. You can also pull only one [Pulsar image](https://hub.docker.com/r/apachepulsar/pulsar-all/tags) and create three containers with this image. This tutorial takes the second option as an example.
-
-### Pull a Pulsar image
-You can pull a Pulsar image from [Docker Hub](https://hub.docker.com/r/apachepulsar/pulsar-all/tags) with the following command.
+## Pull a Pulsar image
+You can pull a Pulsar image from Docker Hub with the following command. If you want to use some connectors, you can use apachepulsar/pulsar-all there.
 
-```shell
+```java
 docker pull apachepulsar/pulsar-all:latest
 ```
+## Create containers
+* Create zookeeper container
+
+```
+docker run -it --privileged=true -u=root --name zookeeper apachepulsar/pulsar-all:latest /bin/bash

Review Comment:
   Why do we use `-it` to start an interactive tty here? We should start the container in the background by using the `-d` options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org