[GitHub] spark pull request: [SPARK-4107] Fix incorrect usage of FileChanne...

[aarondav <gi...@git.apache.org>]

Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2969#discussion_r19451883
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/TachyonStore.scala ---
    @@ -105,25 +106,17 @@ private[spark] class TachyonStore(
           return None
         }
         val is = file.getInStream(ReadType.CACHE)
    -    var buffer: ByteBuffer = null
    +    assert (is != null)
         try {
    -      if (is != null) {
    --- End diff --
    
    I checked the source code for all releases back until 0.4.0 (which is the first one Spark supports), and it's true that `is` cannot be null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org