You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Leigh Anderson (JIRA)" <ji...@apache.org> on 2010/06/28 11:46:50 UTC

[jira] Updated: (WW-3461) Don't hold locks as long when creating validators in AnnotationActionValidatorManager

     [ https://issues.apache.org/jira/browse/WW-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leigh Anderson updated WW-3461:
-------------------------------

    Attachment: validatormanager.patch

> Don't hold locks as long when creating validators in AnnotationActionValidatorManager
> -------------------------------------------------------------------------------------
>
>                 Key: WW-3461
>                 URL: https://issues.apache.org/jira/browse/WW-3461
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.6
>            Reporter: Leigh Anderson
>         Attachments: validatormanager.patch
>
>
> Under load, the lock held in AnnotationActionValidatorManager.getValidators on validatorCache becomes contended. This lock is currently held while all the validators are created. The attached patch reduces the scope of the lock to just doing the cache lookup + taking a defensive copy of the list of validators for that key.  This improved throughput and latency in our tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.