You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2024/01/10 11:52:19 UTC
[PR] MINIFICPP-2285 Archive artifacts of python compatibility verification CI flow [nifi-minifi-cpp]
lordgamez opened a new pull request, #1714:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1714
https://issues.apache.org/jira/browse/MINIFICPP-2285
------------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2285 Archive artifacts of python compatibility verification CI flow [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #1714:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1714#discussion_r1447303095
##########
.github/workflows/verify-python-compatibility.yml:
##########
@@ -82,3 +83,9 @@ jobs:
output-to: 'step-summary'
list-tests: 'failed'
list-suites: 'failed'
+ - name: Upload artifact
+ if: failure()
+ uses: actions/upload-artifact@v3
+ with:
+ name: behavex_output
Review Comment:
Wouldn't you also have to rename the output on the source side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2285 Archive artifacts of python compatibility verification CI flow [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1714:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1714#discussion_r1447305688
##########
.github/workflows/verify-python-compatibility.yml:
##########
@@ -82,3 +83,9 @@ jobs:
output-to: 'step-summary'
list-tests: 'failed'
list-suites: 'failed'
+ - name: Upload artifact
+ if: failure()
+ uses: actions/upload-artifact@v3
+ with:
+ name: behavex_output
Review Comment:
Based on this https://github.com/actions/upload-artifact?tab=readme-ov-file#upload-an-entire-directory the artifact name doesnt have to correlate to the source file/dir name so I think this might be sufficient. (Still havent tested it though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2285 Archive artifacts of python compatibility verification CI flow [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1714: MINIFICPP-2285 Archive artifacts of python compatibility verification CI flow
URL: https://github.com/apache/nifi-minifi-cpp/pull/1714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2285 Archive artifacts of python compatibility verification CI flow [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1714:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1714#discussion_r1447287013
##########
.github/workflows/verify-python-compatibility.yml:
##########
@@ -82,3 +83,9 @@ jobs:
output-to: 'step-summary'
list-tests: 'failed'
list-suites: 'failed'
+ - name: Upload artifact
+ if: failure()
+ uses: actions/upload-artifact@v3
+ with:
+ name: behavex_output
Review Comment:
If there are multiple failures, it will overwrite the uploaded files so only the last one will remain.
This might solve this issue (I didnt test it)
```suggestion
name: ${{ matrix.platform.name }}_behavex_output
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2285 Archive artifacts of python compatibility verification CI flow [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1714:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1714#discussion_r1447365528
##########
.github/workflows/verify-python-compatibility.yml:
##########
@@ -82,3 +83,9 @@ jobs:
output-to: 'step-summary'
list-tests: 'failed'
list-suites: 'failed'
+ - name: Upload artifact
+ if: failure()
+ uses: actions/upload-artifact@v3
+ with:
+ name: behavex_output
Review Comment:
Good point, added an id prefix (to avoid spaces in the names) in b63e14955e800e97b33517fd96635abeec98a341 and tested it in https://github.com/lordgamez/nifi-minifi-cpp/actions/runs/7475211172, seems to be working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2285 Archive artifacts of python compatibility verification CI flow [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on code in PR #1714:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1714#discussion_r1447287013
##########
.github/workflows/verify-python-compatibility.yml:
##########
@@ -82,3 +83,9 @@ jobs:
output-to: 'step-summary'
list-tests: 'failed'
list-suites: 'failed'
+ - name: Upload artifact
+ if: failure()
+ uses: actions/upload-artifact@v3
+ with:
+ name: behavex_output
Review Comment:
If there are multiple failures, it will overwrite the uploaded file so only the last one will remain.
This might solve this issue (I didnt test it)
```suggestion
name: ${{ matrix.platform.name }}_behavex_output
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2285 Archive artifacts of python compatibility verification CI flow [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1714:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1714#discussion_r1447365528
##########
.github/workflows/verify-python-compatibility.yml:
##########
@@ -82,3 +83,9 @@ jobs:
output-to: 'step-summary'
list-tests: 'failed'
list-suites: 'failed'
+ - name: Upload artifact
+ if: failure()
+ uses: actions/upload-artifact@v3
+ with:
+ name: behavex_output
Review Comment:
Good point, added an id prefix (to avoid spaces in the names) in b63e14955e800e97b33517fd96635abeec98a341 and tested it in https://github.com/lordgamez/nifi-minifi-cpp/actions/runs/7475211172, seems to upload the correct artifacts for each platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org