You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/08/07 12:01:33 UTC
[GitHub] [incubator-echarts] dr-itz opened a new pull request #13100: fix(tooltip): keep axis tooltip open on refresh
dr-itz opened a new pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Fix a tooltip disappearing when tooltip trigger is "axis" and data is refreshed.
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
Chart with datazoom slider and live update every few seconds. The slider is somewhere in the middle with a fixed value range. When the user hovers over the data, the tooltip with trigger "axis" shows correctly. But as soon as new data is pushed to the chart the tooltip disappears. This PR fixes that.
### After: How is it fixed in this PR?
Tooltip with trigger axis stays when data is refresehd.
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-680537186
LGTM. Clearing `_lastDataByCoordSys` seems to be a mistake. Thanks for the work! @dr-itz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] dr-itz commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
dr-itz commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-674908038
> @dr-itz 4.9 is the last one which will be released in few days.
thanks for letting me know. I'd really appreciate this PR here to be part of 4.9 since it's something we no proper workaround for.
Of course I'll do the fix for `next` as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] dr-itz commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
dr-itz commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-675390990
I only just realized that there is a `_lastDataByCoordSys` already, so this might be simpler than this.
Btw 😍 the move to TypeScript in `next`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] dr-itz commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
dr-itz commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-680048505
sorry for the delay..I finally found some time and rebased this to `next`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] dr-itz commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
dr-itz commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-675470177
> I only just realized that there is a `_lastDataByCoordSys` already, so this might be simpler than this.
changed it to use that. It's simpler and works as expected. I also tested the non-axis trigger and couldn't find any problem. I'm not familiar enough with this to see why `_lastDataByCoordSys` was cleared in `render()`, so I'm not sure about that one. I think `_tryShow()` and `manuallyHideTip()` should clear it when necessary.
I'll rebase for `next` later 😉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-674911133
I'm afraid that's too late, 4.9 has been voted through, so we cannot add any feature or fix in this release @dr-itz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-674913742
If this feature were really urgent to you, I suggest to build ECharts by yourself. @dr-itz
@Ovilia @100pah @pissang Should we add this PR in 5.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-674897001
@dr-itz 4.9 is the last one which will be released in few days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] dr-itz commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
dr-itz commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-674882697
> @dr-itz Thanks, but could you make a PR to `next` branch?
sure, will do. Out of curiosity, will there be another 4.x.y release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-680537186
LGTM. Clear `_lastDataByCoordSys` seems to be a mistake. Thanks for the work! @dr-itz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-680537755
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13100: fix(tooltip): keep axis tooltip open on refresh
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #13100:
URL: https://github.com/apache/incubator-echarts/pull/13100#issuecomment-673257991
@dr-itz Thanks, but could you make a PR to `next` branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org