[jira] [Commented] (CASSANDRA-10145) Change protocol to allow sending key space independent of query string

["Robert Stupp (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966295#comment-15966295 ] 

Robert Stupp commented on CASSANDRA-10145:
------------------------------------------

I've kicked off CI a while ago and it's fine.
||trunk|[branch|https://github.com/apache/cassandra/compare/trunk...snazy:10145-ks-in-proto-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-10145-ks-in-proto-trunk-testall/lastSuccessfulBuild/]|[dtest|http://cassci.datastax.com/view/Dev/view/snazy/job/snazy-10145-ks-in-proto-trunk-dtest/lastSuccessfulBuild/]

The patch looks pretty good. Just one thing: {{SerDeserTest}} should also check for the new, optional {{keyspace}} parameter - I've updated the test for that.
I think, we can go ahead and get this committed, if you are ok with the utest change.

> Change protocol to allow sending key space independent of query string
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-10145
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10145
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Vishy Kasar
>            Assignee: Sandeep Tamhankar
>              Labels: client-impacting, protocolv5
>             Fix For: 4.0
>
>         Attachments: 10145-trunk.txt
>
>
> Currently keyspace is either embedded in the query string or set through "use keyspace" on a connection by client driver. 
> There are practical use cases where client user has query and keyspace independently. In order for that scenario to work, they will have to create one client session per keyspace or have to resort to some string replace hackery.
> It will be nice if protocol allowed sending keyspace separately from the query. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)