You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jason Bausewein <ja...@tier3.com> on 2012/07/03 21:20:55 UTC
Review Request: Fix deployDataCenter.py to allow creating basic zone with or
without security groups
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5726/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Fixed deployDataCenter.py to select the correct network offering based on if security groups are enabled. Also added default value to configGenerator.py for basic setup.
This addresses bug none.
Diffs
-----
tools/marvin/marvin/configGenerator.py 1e84f90
tools/marvin/marvin/deployDataCenter.py 5c7880e
Diff: https://reviews.apache.org/r/5726/diff/
Testing
-------
Created basic setup with and without security groups enabled.
Thanks,
Jason Bausewein
Re: Review Request: Fix deployDataCenter.py to allow creating basic zone
with or without security groups
Posted by disheng su <ed...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5726/#review8853
-----------------------------------------------------------
Ship it!
Applied, thanks for your patch.
- disheng su
On July 3, 2012, 7:20 p.m., Jason Bausewein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5726/
> -----------------------------------------------------------
>
> (Updated July 3, 2012, 7:20 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Fixed deployDataCenter.py to select the correct network offering based on if security groups are enabled. Also added default value to configGenerator.py for basic setup.
>
>
> This addresses bug none.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/configGenerator.py 1e84f90
> tools/marvin/marvin/deployDataCenter.py 5c7880e
>
> Diff: https://reviews.apache.org/r/5726/diff/
>
>
> Testing
> -------
>
> Created basic setup with and without security groups enabled.
>
>
> Thanks,
>
> Jason Bausewein
>
>