You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/18 05:40:57 UTC

[GitHub] [rocketmq-clients] aaron-ai opened a new pull request, #157: Bugfix: blocking message receiveing may exhausts all async worker threads

aaron-ai opened a new pull request, #157:
URL: https://github.com/apache/rocketmq-clients/pull/157

   Fixes #156 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-clients] aaron-ai merged pull request #157: Bugfix: blocking message receiveing may exhausts all async worker threads

Posted by GitBox <gi...@apache.org>.
aaron-ai merged PR #157:
URL: https://github.com/apache/rocketmq-clients/pull/157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-clients] aaron-ai commented on pull request #157: Bugfix: blocking message receiveing may exhausts all async worker threads

Posted by GitBox <gi...@apache.org>.
aaron-ai commented on PR #157:
URL: https://github.com/apache/rocketmq-clients/pull/157#issuecomment-1219060115

   @xdkxlk PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #157: Bugfix: blocking message receiveing may exhausts all async worker threads

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #157:
URL: https://github.com/apache/rocketmq-clients/pull/157#issuecomment-1219060811

   # [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/157?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#157](https://codecov.io/gh/apache/rocketmq-clients/pull/157?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (75eac59) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/7e6dc0ba4ac6c10338b7a675c67d3261d77b7886?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e6dc0b) will **increase** coverage by `0.21%`.
   > The diff coverage is `60.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #157      +/-   ##
   ============================================
   + Coverage     30.63%   30.84%   +0.21%     
   - Complexity      550      552       +2     
   ============================================
     Files           189      189              
     Lines          8612     8624      +12     
     Branches        283      284       +1     
   ============================================
   + Hits           2638     2660      +22     
   + Misses         5835     5822      -13     
   - Partials        139      142       +3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | java | `52.34% <60.00%> (+0.41%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/157?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/rocketmq/client/java/impl/ClientManager.java](https://codecov.io/gh/apache/rocketmq-clients/pull/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50TWFuYWdlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...mq/client/java/impl/consumer/ProcessQueueImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvY29uc3VtZXIvUHJvY2Vzc1F1ZXVlSW1wbC5qYXZh) | `60.59% <33.33%> (-0.42%)` | :arrow_down: |
   | [...apache/rocketmq/client/java/rpc/RpcClientImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL3JwYy9ScGNDbGllbnRJbXBsLmphdmE=) | `85.50% <66.66%> (-4.82%)` | :arrow_down: |
   | [...e/rocketmq/client/java/impl/ClientManagerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50TWFuYWdlckltcGwuamF2YQ==) | `82.35% <100.00%> (ø)` | |
   | [...cketmq/client/java/impl/consumer/ConsumerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvY29uc3VtZXIvQ29uc3VtZXJJbXBsLmphdmE=) | `74.59% <100.00%> (-0.21%)` | :arrow_down: |
   | [...g/apache/rocketmq/client/java/impl/ClientImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/157/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50SW1wbC5qYXZh) | `38.46% <0.00%> (+5.53%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-clients] xdkxlk commented on pull request #157: Bugfix: blocking message receiveing may exhausts all async worker threads

Posted by GitBox <gi...@apache.org>.
xdkxlk commented on PR #157:
URL: https://github.com/apache/rocketmq-clients/pull/157#issuecomment-1219113211

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org