You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2012/10/12 17:51:02 UTC
[jira] [Created] (BOOKKEEPER-431) Duplicate definition of
COOKIES_NODE
Flavio Junqueira created BOOKKEEPER-431:
-------------------------------------------
Summary: Duplicate definition of COOKIES_NODE
Key: BOOKKEEPER-431
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
Project: Bookkeeper
Issue Type: Improvement
Affects Versions: 4.1.0
Reporter: Flavio Junqueira
Priority: Minor
Fix For: 4.2.0
Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-431) Duplicate definition of
COOKIES_NODE
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476059#comment-13476059 ]
Sijie Guo commented on BOOKKEEPER-431:
--------------------------------------
seems that we had BOOKIE_COOKIE_PATH first in Cookie.java. then a fix to exclude Cookie znode from GC introduced COOKIES_NODE in AbstractZkLedgerManager. Then BOOKKEEPER-263 remove hard coded path introduced COOKIE_NODE in Cookie.java.
I agreed that it would be better to maintain constants in single place to avoid duplications.
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-431) Duplicate definition of
COOKIES_NODE
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508263#comment-13508263 ]
Flavio Junqueira commented on BOOKKEEPER-431:
---------------------------------------------
Hi Uma, Do you think you'll have time to generate a patch for this one?
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (BOOKKEEPER-431) Duplicate definition of
COOKIES_NODE
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G reassigned BOOKKEEPER-431:
----------------------------------------------
Assignee: Uma Maheswara Rao G
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-431) Duplicate definition of
COOKIES_NODE
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508887#comment-13508887 ]
Uma Maheswara Rao G commented on BOOKKEEPER-431:
------------------------------------------------
Hi Flavio, Sorry for the late on this JIRA. From past few days I was not getting time due to travels and internal schedules. I will sit tomorrow and generate patch for it. Also will check the reviews if I can provide some comments on others to get 4.2 out soon.
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-431) Duplicate definition of
COOKIES_NODE
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475113#comment-13475113 ]
Flavio Junqueira commented on BOOKKEEPER-431:
---------------------------------------------
Yeah, I'd rather have the constants in one single place. COOKIE_NODE was introduced in BOOKKEEPER-263, but before that we had BOOKIE_COOKIE_PATH, so I'm not entirely sure what the history of duplication is. Ivan, Sijie, do you guys have any other insight to add here?
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-431) Duplicate definition of
COOKIES_NODE
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475099#comment-13475099 ]
Flavio Junqueira commented on BOOKKEEPER-431:
---------------------------------------------
Actually, Cookie.java defines COOKIE_NODE while AbstractZkLedgerManager defines COOKIES_NODE. I also noticed that AVAILABLE_NODE is duplicated. Is it for readability reasons? Shouldn't we have that in a single place?
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Priority: Minor
> Fix For: 4.2.0
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-431) Duplicate definition of
COOKIES_NODE
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475101#comment-13475101 ]
Uma Maheswara Rao G commented on BOOKKEEPER-431:
------------------------------------------------
How about having a constants file and maintaining all such consts at place?
If we maintain the constants inside specific files, it is very easy to duplicate the consts.
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-431) Duplicate definition of
COOKIES_NODE
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477938#comment-13477938 ]
Ivan Kelly commented on BOOKKEEPER-431:
---------------------------------------
I can't remember what reason there was for adding the second one (possibly to avoid cross package dependencies). In any case, I do agree that it's better to have just one, for COOKIE_NODE and for AVAILABLE_NODE
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-431) Duplicate definition of
COOKIES_NODE
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated BOOKKEEPER-431:
-------------------------------------------
Attachment: BOOKKEEPER-431.patch
> Duplicate definition of COOKIES_NODE
> ------------------------------------
>
> Key: BOOKKEEPER-431
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-431
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.1.0
> Reporter: Flavio Junqueira
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-431.patch
>
>
> Is it necessary two definitions of COOKIES_NODE, one in cookie.java and one in AbstractZkLedgerManager?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira