You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2014/12/01 20:23:30 UTC
Re: Review Request 28321: Introduce libevent header and
implementation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28321/
-----------------------------------------------------------
(Updated Dec. 1, 2014, 7:23 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Remove unused / refactored function declarations.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
3rdparty/libprocess/src/libevent.hpp PRE-CREATION
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
Diff: https://reviews.apache.org/r/28321/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28321: Introduce libevent header and
implementation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Dec. 2, 2014, 10:13 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/libevent.cpp, line 39
> > <https://reviews.apache.org/r/28321/diff/3/?file=779192#file779192line39>
> >
> > Can we get out better error messages here? Maybe a TODO?
There is currently no way to get a return code here. From the implementation it seems the only way this can fail is if we can't allocate memory for the structure or the default configuration is somehow invalid.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28321/#review63591
-----------------------------------------------------------
On Dec. 3, 2014, 7:45 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28321/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2014, 7:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
> 3rdparty/libprocess/src/libevent.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
>
> Diff: https://reviews.apache.org/r/28321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28321: Introduce libevent header and
implementation.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28321/#review63591
-----------------------------------------------------------
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28321/#comment105867>
What is r?
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28321/#comment105865>
r?
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28321/#comment105866>
!= NULL?
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28321/#comment105870>
Can we get out better error messages here? Maybe a TODO?
- Benjamin Hindman
On Dec. 1, 2014, 7:23 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28321/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 7:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
> 3rdparty/libprocess/src/libevent.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
>
> Diff: https://reviews.apache.org/r/28321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28321: Introduce libevent header and
implementation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28321/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 5:11 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
More informative configure error messages.
Fix style.
Add comment to libevent debugging activation.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204
3rdparty/libprocess/src/libevent.hpp PRE-CREATION
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
Diff: https://reviews.apache.org/r/28321/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28321: Introduce libevent header and
implementation.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28321/#review63886
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/28321/#comment106228>
Indent +2 please.
3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/28321/#comment106229>
See comment in other review about error message please.
3rdparty/libprocess/src/libevent.hpp
<https://reviews.apache.org/r/28321/#comment106230>
Can we add a comment explaining what this is just as we did in libev.hpp?
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28321/#comment106199>
s/void */void* /
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28321/#comment106200>
Can you elaborate on this comment with a complete sentence? Or just remove this line?
3rdparty/libprocess/src/libevent.cpp
<https://reviews.apache.org/r/28321/#comment106201>
Did you mean s/event_base/event_base_new/ here?
- Benjamin Hindman
On Dec. 4, 2014, 12:19 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28321/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2014, 12:19 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
> 3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204
> 3rdparty/libprocess/src/libevent.hpp PRE-CREATION
> 3rdparty/libprocess/src/libevent.cpp PRE-CREATION
> 3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
>
> Diff: https://reviews.apache.org/r/28321/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 28321: Introduce libevent header and
implementation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28321/
-----------------------------------------------------------
(Updated Dec. 4, 2014, 12:19 a.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Add configure check for libevent_pthreads.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
3rdparty/libprocess/configure.ac 314c8b842d07e1344659449866f7e85c48854204
3rdparty/libprocess/src/libevent.hpp PRE-CREATION
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
Diff: https://reviews.apache.org/r/28321/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28321: Introduce libevent header and
implementation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28321/
-----------------------------------------------------------
(Updated Dec. 3, 2014, 7:45 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Rename return code from event_base_loop to result.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
3rdparty/libprocess/src/libevent.hpp PRE-CREATION
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
Diff: https://reviews.apache.org/r/28321/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 28321: Introduce libevent header and
implementation.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28321/
-----------------------------------------------------------
(Updated Dec. 3, 2014, 7:33 p.m.)
Review request for mesos, Benjamin Hindman and Niklas Nielsen.
Changes
-------
Rebased. style.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am aebd281da41325a0246f5c57780928afc22a1baa
3rdparty/libprocess/src/libevent.hpp PRE-CREATION
3rdparty/libprocess/src/libevent.cpp PRE-CREATION
3rdparty/libprocess/src/process.cpp 89e0e0cc15ab3fc8b1156906ef5f9b314c72c7e3
Diff: https://reviews.apache.org/r/28321/diff/
Testing
-------
Thanks,
Joris Van Remoortere