[jira] [Commented] (GEODE-4058) Need to clean up disk files in JUnit4TestCase tearDown

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279423#comment-16279423 ] 

ASF GitHub Bot commented on GEODE-4058:
---------------------------------------

upthewaterspout opened a new pull request #1123: GEODE-4058: Always delete disk files after every test runs
URL: https://github.com/apache/geode/pull/1123
 
 
   Avoid hangs due to leftover disk files by making sure that all tests
   that use JUnit4DistributedCase have their disk files cleaned up after
   the test, including a locators ConfigDiskDir_
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Need to clean up disk files in JUnit4TestCase tearDown
> ------------------------------------------------------
>
>                 Key: GEODE-4058
>                 URL: https://issues.apache.org/jira/browse/GEODE-4058
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>             Fix For: 1.4.0
>
>
> We've been seeing some tests hang in precheckin.
> I tracked down one of the hangs to running RollingUpgrade2DUnitTest followed by FixedPRSinglehopDUnitTest. What both tests cases are doing is starting a locator in vm-2 that uses a ConfigDiskDir_directory. The disk files left by RollingUpgrade2DunitTest are causing FixedPRSindleHopDUnitTest to wait for other members to start up.
> We should make sure we always clean up these files after the test finishes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)