[GitHub] [incubator-druid] himanshug commented on a change in pull request #7606: Set direct memory if unable to detect JVM config

[GitBox <gi...@apache.org>]

himanshug commented on a change in pull request #7606: Set direct memory if unable to detect JVM config
URL: https://github.com/apache/incubator-druid/pull/7606#discussion_r282205588
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/DruidProcessingConfig.java
 ##########
 @@ -52,7 +52,22 @@ public int intermediateComputeSizeBytes()
       return computedBufferSizeBytes.get();
     }
 
-    long directSizeBytes = JvmUtils.getRuntimeInfo().getDirectMemorySizeBytes();
+    long directSizeBytes;
+    try {
+      directSizeBytes = JvmUtils.getRuntimeInfo().getDirectMemorySizeBytes();
 
 Review comment:
   so this always fails for jdk 9 onwards ?
   if yes, that means if user wanted buffers of size DEFAULT_PROCESSING_BUFFER_SIZE_BYTES , they would configure that number but instead get buffers of size 25%-of-max-heap/totalNumBuffers ?
   in that case we need to change line 49 to have a different way of detecting whether user explicitly provided sizeBytes config .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org