[jira] [Commented] (STORM-1048) Add generic type to conf arugment of ISpout.open

["Karl Richter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405151#comment-16405151 ] 

Karl Richter commented on STORM-1048:
-------------------------------------

This has been fixed meanwhile.

Related: https://issues.apache.org/jira/browse/STORM-2999

> Add generic type to conf arugment of ISpout.open
> ------------------------------------------------
>
>                 Key: STORM-1048
>                 URL: https://issues.apache.org/jira/browse/STORM-1048
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-core
>    Affects Versions: 0.10.0
>            Reporter: Karl Richter
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Changing the signature of `ISpout.open` from `void open(Map conf, TopologyContext context, SpoutOutputCollector collector)` to `void open(Map<Object,Object> conf, TopologyContext context, SpoutOutputCollector collector)` would allow, but not force callers to write warning-free code. The change should be backwards compatible because callers can ignore it like storm currently does in the `ISpout` interface.
> The changes would only avoid compiler warnings about unchecked conversations and rawtypes. It would make the code longer and there'd be no functional change as `Map` defaults to `Map<Object, Object>` after type erasure.
> Alternatively a generic type for the key and the value of `conf` could be introduced in `ISpout`.
> I volunteer to do it in the complete source.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)