[jira] [Commented] (LUCENE-6264) Add SuppressFileSystems annotation.

["Dawid Weiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328090#comment-14328090 ] 

Dawid Weiss commented on LUCENE-6264:
-------------------------------------

Looks good to me. The only note is probably that TestRuleTemporaryFilesCleanup doesn't really reflect the actual function of this rule. Should be something more like "TestRuleSetupCustomFileSystem"...

> Add SuppressFileSystems annotation.
> -----------------------------------
>
>                 Key: LUCENE-6264
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6264
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Robert Muir
>         Attachments: LUCENE-6264.patch
>
>
> kinda like SuppressCodecs, to make it easier to disable cornercases that don't play with anything we are doing at this level.
> the one example we have today is LUCENE-5574, the bug just doesnt happen on windows because you can't delete open files there, so the test won't work. Today it uses a hacky method to disable mock windowsFS.
> But being able to easily turn these off for rare exotic cases, will make it easier to improve/add them for the general case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org