You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2013/11/08 08:01:25 UTC
Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference,
cleaned it. As well added Uniform naming convention
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-5099
https://issues.apache.org/jira/browse/CLOUDSTACK-5099
Repository: cloudstack-git
Description
-------
1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it.
3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote
Diffs
-----
Diff: https://reviews.apache.org/r/15341/diff/
Testing
-------
Thanks,
Santhosh Edukulla
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference,
cleaned it. As well added Uniform naming convention
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/#review28506
-----------------------------------------------------------
i can't see the diff
- SrikanteswaraRao Talluri
On Nov. 8, 2013, 7:01 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15341/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 7:01 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5099
> https://issues.apache.org/jira/browse/CLOUDSTACK-5099
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
> 2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it.
> 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/15341/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference,
cleaned it. As well added Uniform naming convention
Posted by Girish Shilamkar <gi...@clogeny.com>.
> On Nov. 8, 2013, 10:11 a.m., Girish Shilamkar wrote:
> > Santhosh,
> >
> > Please update the diff instead of uploading them as different file.
Also the commit header should be "CLOUDSTACK-5099: <Heading>" This will ensure that the jira ticket also gets updated upon merge.
- Girish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/#review28528
-----------------------------------------------------------
On Nov. 8, 2013, 7:16 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15341/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 7:16 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5099
> https://issues.apache.org/jira/browse/CLOUDSTACK-5099
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
> 2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it.
> 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/15341/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> patch file
> https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch
> patchfile
> https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference,
cleaned it. As well added Uniform naming convention
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/#review28528
-----------------------------------------------------------
Santhosh,
Please update the diff instead of uploading them as different file.
- Girish Shilamkar
On Nov. 8, 2013, 7:16 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15341/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 7:16 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5099
> https://issues.apache.org/jira/browse/CLOUDSTACK-5099
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
> 2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it.
> 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/15341/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> patch file
> https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch
> patchfile
> https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference,
cleaned it. As well added Uniform naming convention
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/#review28531
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Nov. 8, 2013, 10:43 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15341/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 10:43 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5099
> https://issues.apache.org/jira/browse/CLOUDSTACK-5099
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
> 2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it.
> 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/utils.py 4d048f0
> tools/marvin/marvin/remoteSSHClient.py fea9b12
>
> Diff: https://reviews.apache.org/r/15341/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> patch file
> https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch
> patchfile
> https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference,
cleaned it. As well added Uniform naming convention
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/#review28532
-----------------------------------------------------------
Ship it!
Ship It!
- SrikanteswaraRao Talluri
On Nov. 8, 2013, 10:43 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15341/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2013, 10:43 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-5099
> https://issues.apache.org/jira/browse/CLOUDSTACK-5099
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
> 2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it.
> 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote
>
>
> Diffs
> -----
>
> tools/marvin/marvin/integration/lib/utils.py 4d048f0
> tools/marvin/marvin/remoteSSHClient.py fea9b12
>
> Diff: https://reviews.apache.org/r/15341/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> patch file
> https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch
> patchfile
> https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference,
cleaned it. As well added Uniform naming convention
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/
-----------------------------------------------------------
(Updated Nov. 8, 2013, 10:43 a.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-5099
https://issues.apache.org/jira/browse/CLOUDSTACK-5099
Repository: cloudstack-git
Description
-------
1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it.
3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote
Diffs (updated)
-----
tools/marvin/marvin/integration/lib/utils.py 4d048f0
tools/marvin/marvin/remoteSSHClient.py fea9b12
Diff: https://reviews.apache.org/r/15341/diff/
Testing
-------
File Attachments
----------------
patch file
https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch
patchfile
https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch
Thanks,
Santhosh Edukulla
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference,
cleaned it. As well added Uniform naming convention
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/
-----------------------------------------------------------
(Updated Nov. 8, 2013, 7:16 a.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Changes
-------
Added missing patch file
Bugs: CLOUDSTACK-5099
https://issues.apache.org/jira/browse/CLOUDSTACK-5099
Repository: cloudstack-git
Description
-------
1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it.
3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote
Diffs
-----
Diff: https://reviews.apache.org/r/15341/diff/
Testing
-------
File Attachments (updated)
----------------
patch file
https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch
patchfile
https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch
Thanks,
Santhosh Edukulla