You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Monis Majeed <mo...@citrix.com> on 2014/05/19 13:36:42 UTC
Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282
Repository: cloudstack-git
Description
-------
Automated network API Tests and uploaded patch
Diffs
-----
test/integration/component/test_escalations_networks.py PRE-CREATION
tools/marvin/marvin/config/test_data.py 5577ae1
tools/marvin/marvin/lib/base.py 0a6405d
Diff: https://reviews.apache.org/r/21628/diff/
Testing
-------
Executed all the Network tests and uploaded the results file
File Attachments
----------------
results.txt
https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
Thanks,
Monis Majeed
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review43355
-----------------------------------------------------------
Commit ef2012677c8eb47e083a7220dfc30ac001e91567 in cloudstack's branch refs/heads/master from vinayvarmav
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ef20126 ]
CLOUDSTACK-6282 - Divided test_escalations.py into individual files based on functionality and added automed tests for Public IP Addresses
- ASF Subversion and Git Services
On May 19, 2014, 11:36 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:36 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 5577ae1
> tools/marvin/marvin/lib/base.py 0a6405d
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review43356
-----------------------------------------------------------
Commit 378e1da42c235d310df3d39d3d82270ef00546df in cloudstack's branch refs/heads/4.4-forward from vinayvarmav
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=378e1da ]
CLOUDSTACK-6282 - Divided test_escalations.py into individual files based on functionality and added automed tests for Public IP Addresses
- ASF Subversion and Git Services
On May 19, 2014, 11:36 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:36 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 5577ae1
> tools/marvin/marvin/lib/base.py 0a6405d
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review44233
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On May 29, 2014, 3:48 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 3:48 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 52be02d
> tools/marvin/marvin/lib/base.py a7d62e0
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
> Results
> https://reviews.apache.org/media/uploaded/files/2014/05/23/12f03114-aeeb-4856-9450-cce2826c75c3__NetworksResults.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review44235
-----------------------------------------------------------
Patch doesn't apply cleanly on master, Can you make sure that this patch can be applied successfully on master and update the same here.
- SrikanteswaraRao Talluri
On May 29, 2014, 3:48 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 3:48 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 52be02d
> tools/marvin/marvin/lib/base.py a7d62e0
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
> Results
> https://reviews.apache.org/media/uploaded/files/2014/05/23/12f03114-aeeb-4856-9450-cce2826c75c3__NetworksResults.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review44256
-----------------------------------------------------------
Commit cdf4047ce823edcdd73f9a1562abc9c27f473557 in cloudstack's branch refs/heads/master from monism
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=cdf4047 ]
CLOUDSTACK-6282-Added Autometed test for network APIs after incorporating review comments
- ASF Subversion and Git Services
On May 29, 2014, 6:13 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 6:13 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 52be02d
> tools/marvin/marvin/lib/base.py a301e25
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
> Results
> https://reviews.apache.org/media/uploaded/files/2014/05/23/12f03114-aeeb-4856-9450-cce2826c75c3__NetworksResults.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by Monis Majeed <mo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/
-----------------------------------------------------------
(Updated May 29, 2014, 6:13 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Updated latest patch after removing all the whitespaces and extra lines whereever applicable. Review the same and do the needful
Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282
Repository: cloudstack-git
Description
-------
Automated network API Tests and uploaded patch
Diffs (updated)
-----
test/integration/component/test_escalations_networks.py PRE-CREATION
tools/marvin/marvin/config/test_data.py 52be02d
tools/marvin/marvin/lib/base.py a301e25
Diff: https://reviews.apache.org/r/21628/diff/
Testing
-------
Executed all the Network tests and uploaded the results file
File Attachments
----------------
results.txt
https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
Results
https://reviews.apache.org/media/uploaded/files/2014/05/23/12f03114-aeeb-4856-9450-cce2826c75c3__NetworksResults.txt
Thanks,
Monis Majeed
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by Monis Majeed <mo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/
-----------------------------------------------------------
(Updated May 29, 2014, 3:48 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Uploaded latest patch after fixing the compilation error in base.py file changes. Please push this patch to master. Ignore earlier patch
Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282
Repository: cloudstack-git
Description
-------
Automated network API Tests and uploaded patch
Diffs (updated)
-----
test/integration/component/test_escalations_networks.py PRE-CREATION
tools/marvin/marvin/config/test_data.py 52be02d
tools/marvin/marvin/lib/base.py a7d62e0
Diff: https://reviews.apache.org/r/21628/diff/
Testing
-------
Executed all the Network tests and uploaded the results file
File Attachments
----------------
results.txt
https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
Results
https://reviews.apache.org/media/uploaded/files/2014/05/23/12f03114-aeeb-4856-9450-cce2826c75c3__NetworksResults.txt
Thanks,
Monis Majeed
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review44106
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On May 23, 2014, 9:38 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 9:38 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 52be02d
> tools/marvin/marvin/lib/base.py a7d62e0
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
> Results
> https://reviews.apache.org/media/uploaded/files/2014/05/23/12f03114-aeeb-4856-9450-cce2826c75c3__NetworksResults.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by Monis Majeed <mo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/
-----------------------------------------------------------
(Updated May 23, 2014, 9:38 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Modified test_escalations_networs.py file as per the review comments. Uploaded the patch after modifications. Also uploaded results file
Bugs: CLOUDSTACK-6282
https://issues.apache.org/jira/browse/CLOUDSTACK-6282
Repository: cloudstack-git
Description
-------
Automated network API Tests and uploaded patch
Diffs (updated)
-----
test/integration/component/test_escalations_networks.py PRE-CREATION
tools/marvin/marvin/config/test_data.py 52be02d
tools/marvin/marvin/lib/base.py a7d62e0
Diff: https://reviews.apache.org/r/21628/diff/
Testing
-------
Executed all the Network tests and uploaded the results file
File Attachments (updated)
----------------
results.txt
https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
Results
https://reviews.apache.org/media/uploaded/files/2014/05/23/12f03114-aeeb-4856-9450-cce2826c75c3__NetworksResults.txt
Thanks,
Monis Majeed
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review43353
-----------------------------------------------------------
Commit d43d28ee84424359d5847fa6e53dabad176f037e in cloudstack's branch refs/heads/4.4-forward from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d43d28e ]
Revert "CLOUDSTACK-6282 - Divided test_escalations.py into individual files based on functionality and added automed tests for Public IP Addresses"
This reverts commit c5634570e25900f2e83a77a2ad20ad267bba8202.
- ASF Subversion and Git Services
On May 19, 2014, 11:36 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:36 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 5577ae1
> tools/marvin/marvin/lib/base.py 0a6405d
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review43351
-----------------------------------------------------------
Commit c5634570e25900f2e83a77a2ad20ad267bba8202 in cloudstack's branch refs/heads/4.4-forward from vinayvarmav
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c563457 ]
CLOUDSTACK-6282 - Divided test_escalations.py into individual files based on functionality and added automed tests for Public IP Addresses
- ASF Subversion and Git Services
On May 19, 2014, 11:36 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:36 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 5577ae1
> tools/marvin/marvin/lib/base.py 0a6405d
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review43350
-----------------------------------------------------------
Commit 2ba6322030dc24e6888407c78a8573f8b0d04bc9 in cloudstack's branch refs/heads/master from vinayvarmav
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2ba6322 ]
CLOUDSTACK-6282 - Divided test_escalations.py into individual files based on functionality and added automed tests for Public IP Addresses
- ASF Subversion and Git Services
On May 19, 2014, 11:36 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:36 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 5577ae1
> tools/marvin/marvin/lib/base.py 0a6405d
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by Vinay Varma <vi...@citrix.com>.
> On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_escalations_networks.py, lines 434-435
> > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line434>
> >
> > May be get the count as it is for before vpc list, need not be zero? Especially if multiple tests run in parallel, there could be a possibility we may get the count varying.
Here we are checking for Zero VPCs in that account and also kept asserts as such. This we have followed for all the automated tests. So we shall leave it as such for now
> On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_escalations_networks.py, line 640
> > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line640>
> >
> > Move this to above line after vpc creation.
Here we are creating VPC and then Network under VPC, so first we need to clean Network and then only VPC, if we are adding cleaning of VPC first and network later then during cleanup it was giving error saying "network exists in the vpc"
> On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_escalations_networks.py, line 949
> > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line949>
> >
> > Not clear with this check. Why cant we just append to cleanup?
We wanted this check as we need not add all the VM's created as we are deleting one VM in test itself.
> On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_escalations_networks.py, line 1108
> > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line1108>
> >
> > Can this be moved after create?
Here we are creating VPC and then Network under VPC, so first we need to clean Network and then only VPC, if we are adding cleaning of VPC first and network later then during cleanup it was giving error saying "network exists in the vpc"
> On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_escalations_networks.py, line 2091
> > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line2091>
> >
> > Do we require some time to check whether vpc started or failed?
We donot need any time, since it is async call framework is handling
> On May 21, 2014, 6:30 a.m., Santhosh Edukulla wrote:
> > test/integration/component/test_escalations_networks.py, line 2471
> > <https://reviews.apache.org/r/21628/diff/1/?file=584175#file584175line2471>
> >
> > For delete we require some time to wait?
We donot need any time, since it is async call framework is handling
- Vinay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review43594
-----------------------------------------------------------
On May 19, 2014, 11:36 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:36 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 5577ae1
> tools/marvin/marvin/lib/base.py 0a6405d
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review43594
-----------------------------------------------------------
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77881>
Rename services to test data or some thing better. Its not an issue, but services seems to be little misnomer.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77882>
Step1 repeated twice.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77860>
We dont need this check, its verified at line 320 earlier.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77861>
Move this clean up to above assert. Otherwise it will miss from cleanup.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77862>
These 3 statements seems to be widely used. Can we move them to a common function?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77867>
May be get the count as it is for before vpc list, need not be zero? Especially if multiple tests run in parallel, there could be a possibility we may get the count varying.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77863>
Can test name be changed based upon description, currently its very generic?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77864>
These line needs to be moved up.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77865>
Similarly, move these verifications to a commonly used function. That way its easy to maintain.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77866>
Why vpc_count_before is zero?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77868>
Move this to above line after vpc creation.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77870>
Do we wanted to move this assert before cleaning up of network?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77871>
Lot of code is repetitive, may be more can be modularized.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77872>
Test name related to vpc listing ? currently it just mentions normal network creation\deletion.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77873>
Tags were commented.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77874>
Move this line before cleanup.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77875>
Why cant we move this line to after 814 itself? and then we dont require if else.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77876>
Not clear with this check. Why cant we just append to cleanup?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77877>
Can this be moved after create?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77878>
Move this before cleanup.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77880>
Why this check is required? Its take care during validateList itself.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77879>
Move this line before cleanup.
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77883>
Do we require some time to check whether vpc started or failed?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77884>
For delete we require some time to wait?
test/integration/component/test_escalations_networks.py
<https://reviews.apache.org/r/21628/#comment77885>
Do we not require clean up for this creation?
- Santhosh Edukulla
On May 19, 2014, 11:36 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:36 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 5577ae1
> tools/marvin/marvin/lib/base.py 0a6405d
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
>
>
> Thanks,
>
> Monis Majeed
>
>
Re: Review Request 21628: CLOUDSTACK-6282: Automated network API Tests and
uploaded patch
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21628/#review43354
-----------------------------------------------------------
Commit b4ad709d321b79f532721cd65f9ecf9584d68ee6 in cloudstack's branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b4ad709 ]
Revert "CLOUDSTACK-6282 - Divided test_escalations.py into individual files based on functionality and added automed tests for Public IP Addresses"
This reverts commit 2ba6322030dc24e6888407c78a8573f8b0d04bc9.
- ASF Subversion and Git Services
On May 19, 2014, 11:36 a.m., Monis Majeed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21628/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 11:36 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6282
> https://issues.apache.org/jira/browse/CLOUDSTACK-6282
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Automated network API Tests and uploaded patch
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_networks.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 5577ae1
> tools/marvin/marvin/lib/base.py 0a6405d
>
> Diff: https://reviews.apache.org/r/21628/diff/
>
>
> Testing
> -------
>
> Executed all the Network tests and uploaded the results file
>
>
> File Attachments
> ----------------
>
> results.txt
> https://reviews.apache.org/media/uploaded/files/2014/05/19/0574d454-3aae-4cf4-9c45-af8fc678b487__results.txt
>
>
> Thanks,
>
> Monis Majeed
>
>