You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/11/04 21:23:14 UTC
[GitHub] [ignite-3] Berkof opened a new pull request #427: IGNITE-15776 Fix code style issue for sql components
Berkof opened a new pull request #427:
URL: https://github.com/apache/ignite-3/pull/427
[IGNITE-154776](https://issues.apache.org/jira/browse/IGNITE-15776)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on pull request #427: IGNITE-15776 Fix code style issue for sql components
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on pull request #427:
URL: https://github.com/apache/ignite-3/pull/427#issuecomment-962933312
Can you also fix the javadoc for **modules/schema**?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on pull request #427: IGNITE-15776 Fix code style issue for sql components
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on pull request #427:
URL: https://github.com/apache/ignite-3/pull/427#issuecomment-962873746
We have to rollback all changes for **modules/bytecode/src/main/java/com/facebook/presto/bytecode/** and **modules/raft/src/main/java/org/apache/ignite/raft/jraft**, they are in the [excludes](https://github.com/apache/ignite-3/blob/main/parent/pom.xml#L1095).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a change in pull request #427: IGNITE-15776 Fix code style issue for sql components
Posted by GitBox <gi...@apache.org>.
tkalkirill commented on a change in pull request #427:
URL: https://github.com/apache/ignite-3/pull/427#discussion_r744509805
##########
File path: modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java
##########
@@ -66,10 +62,12 @@
import org.apache.ignite.raft.jraft.util.JDKMarshaller;
import org.jetbrains.annotations.Nullable;
+import static org.apache.ignite.raft.jraft.JRaftUtils.addressFromEndpoint;
+
/**
* Raft server implementation on top of forked JRaft library.
*/
-public class JraftServerImpl implements RaftServer {
+public class JRaftServerImpl implements RaftServer {
Review comment:
Please fetch from main
##########
File path: modules/bytecode/src/main/java/com/facebook/presto/bytecode/ClassGenerator.java
##########
@@ -129,7 +129,20 @@ public ClassGenerator dumpClassFilesTo(Optional<Path> dumpClassPath)
Map<String, byte[]> bytecodes = new LinkedHashMap<>();
for (ClassDefinition classDefinition : classDefinitions) {
- // Code associated with a simple class writer was removed due to labels reuse when re-generating the bytecode.
Review comment:
Please fetch from mater
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tledkov-gridgain merged pull request #427: IGNITE-15776 Fix code style issue for sql components
Posted by GitBox <gi...@apache.org>.
tledkov-gridgain merged pull request #427:
URL: https://github.com/apache/ignite-3/pull/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org