You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/02/10 04:54:59 UTC
[I] [C++] Add support for building statistics array for nested types [arrow]
kou opened a new issue, #45474:
URL: https://github.com/apache/arrow/issues/45474
### Describe the enhancement requested
`arrow::RecordBatch::MakeStatisticsArray()` can build a statistics array of a record batch. But it doesn't support nested types yet. We should use the rule that is used by RecordBatch message https://arrow.apache.org/docs/format/Columnar.html#ipc-recordbatch-message to compute column indexes for nested types.
See also: https://arrow.apache.org/docs/format/StatisticsSchema.html#schema
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #45474:
URL: https://github.com/apache/arrow/issues/45474#issuecomment-4470493112
This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 14 days. If this improvement is still desired but has no current owner, please add the 'Status: needs champion' label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #45474:
URL: https://github.com/apache/arrow/issues/45474#issuecomment-2687364181
You can do it by yourself by just adding "take" only comment!
Document: https://arrow.apache.org/docs/developers/bug_reports.html#issue-assignment
Example: https://github.com/apache/arrow/issues/45619#issuecomment-2682564429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "arashandishgar (via GitHub)" <gi...@apache.org>.
arashandishgar commented on issue #45474:
URL: https://github.com/apache/arrow/issues/45474#issuecomment-2694192931
I found that it seems the StringView and BinaryVeiw has not supported in `ValueToArrowType` in `ArrayStatistics`.
https://github.com/apache/arrow/blob/0fbf9823542233c5f32c26534c34cc97ce3f0be2/cpp/src/arrow/array/statistics.h#L57-L66
should I add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "arashandishgar (via GitHub)" <gi...@apache.org>.
arashandishgar commented on issue #45474:
URL: https://github.com/apache/arrow/issues/45474#issuecomment-2687391961
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "arashandishgar (via GitHub)" <gi...@apache.org>.
arashandishgar commented on issue #45474:
URL: https://github.com/apache/arrow/issues/45474#issuecomment-2696765740
> Yes but let's work on it as a separated task. Because `StringView`/`BinaryView` aren't nested types.
I've created the separate issue for this #45664 , However I think it's better to send a pull request for it after the current issue is solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "arashandishgar (via GitHub)" <gi...@apache.org>.
arashandishgar commented on issue #45474:
URL: https://github.com/apache/arrow/issues/45474#issuecomment-2687326569
I've submitted my first pull request which is about to implement extract_regex_span and it is currently under review. I'd like to start working on this issue, However I'm still gaining experience in C++ and it maybe take some time to implement it. Nonetheless, I approciate if you could assign the issue to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "arashandishgar (via GitHub)" <gi...@apache.org>.
arashandishgar commented on issue #45474:
URL: https://github.com/apache/arrow/issues/45474#issuecomment-2687261617
as follow up our privious [conversation](https://github.com/apache/arrow/issues/45560#issuecomment-2687096141) and the implementation of `arrow::RecordBatch::MakeStatisticsArray()`, two things seems does not exist.
1.apporpiate type for nested array
2. lack of the implementation of Depth-first search on column array
3. Missing some array attributes #45639
I think we should address the first case to make it possible the second one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #45474:
URL: https://github.com/apache/arrow/issues/45474#issuecomment-2695496733
Yes but let's work on it as a separated task. Because `StringView`/`BinaryView` aren't nested types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #45474: [C++] Add support for building statistics array for nested types
URL: https://github.com/apache/arrow/issues/45474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #45474:
URL: https://github.com/apache/arrow/issues/45474#issuecomment-4976137885
Done. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Add support for building statistics array for nested types [arrow]
Posted by "andishgar (via GitHub)" <gi...@apache.org>.
andishgar commented on issue #45474:
URL: https://github.com/apache/arrow/issues/45474#issuecomment-4974210125
@kou, could you reopen this? Btw, there is a relevant PR to this issue and I will review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org