You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by gm...@apache.org on 2021/08/23 14:51:41 UTC

[qpid-dispatch] branch main updated: DISPATCH-2233: Comment switchover tests in system_tests_fallback_dest until we figure out the problem. This closes #1344.

This is an automated email from the ASF dual-hosted git repository.

gmurthy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-dispatch.git


The following commit(s) were added to refs/heads/main by this push:
     new e9679c5  DISPATCH-2233: Comment switchover tests in system_tests_fallback_dest until we figure out the problem. This closes #1344.
e9679c5 is described below

commit e9679c519a1028508085ef0033109879ca085b59
Author: Ganesh Murthy <gm...@apache.org>
AuthorDate: Fri Aug 20 16:20:47 2021 -0400

    DISPATCH-2233: Comment switchover tests in system_tests_fallback_dest until we figure out the problem. This closes #1344.
---
 .travis.yml                         |  9 +++++++++
 tests/system_tests_fallback_dest.py | 30 ++++++++++++++++++++++++++++--
 2 files changed, 37 insertions(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index db18f53..7d750f3 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -51,17 +51,20 @@ jobs:
     os: linux
     env:
     - QPID_SYSTEM_TEST_TIMEOUT=300
+    - QPID_SYSTEM_TEST_SKIP_FALLBACK_SWITCHOVER_TEST=True
     - PATH="/usr/bin:$PATH" PROTON_VERSION=main BUILD_TYPE=Debug
     - DISPATCH_CMAKE_ARGS='-DRUNTIME_CHECK=asan'
   - name: "qdrouterd:Coverage"
     os: linux
     env:
     - QPID_SYSTEM_TEST_TIMEOUT=300
+    - QPID_SYSTEM_TEST_SKIP_FALLBACK_SWITCHOVER_TEST=True
     - PATH="/usr/bin:$PATH" PROTON_VERSION=0.35.0 BUILD_TYPE=Coverage
   - name: "qdrouterd:RelWithDebInfo+MemoryDebug (gcc on xenial)"
     os: linux
     env:
     - QPID_SYSTEM_TEST_TIMEOUT=300
+    - QPID_SYSTEM_TEST_SKIP_FALLBACK_SWITCHOVER_TEST=True
     - PATH="/usr/bin:$PATH" PROTON_VERSION=0.35.0 BUILD_TYPE=RelWithDebInfo
     - DISPATCH_CMAKE_ARGS='-DRUNTIME_CHECK=asan -DCMAKE_C_FLAGS=-DQD_MEMORY_DEBUG'
   - name: "qdrouterd:RelWithDebInfo+MemoryDebug (clang on focal)"
@@ -86,6 +89,7 @@ jobs:
     - python -m pip install --user grpcio protobuf
     env:
     - QPID_SYSTEM_TEST_TIMEOUT=300
+    - QPID_SYSTEM_TEST_SKIP_FALLBACK_SWITCHOVER_TEST=True
     - CC=clang-12
     - CXX=clang++-12
     - PATH="/usr/bin:$PATH" PROTON_VERSION=main BUILD_TYPE=RelWithDebInfo
@@ -112,6 +116,7 @@ jobs:
       - sudo apt install python3-grpcio
     env:
       - QPID_SYSTEM_TEST_TIMEOUT=300
+      - QPID_SYSTEM_TEST_SKIP_FALLBACK_SWITCHOVER_TEST=True
       - PROTON_VERSION=main BUILD_TYPE=RelWithDebInfo
       - DISPATCH_CMAKE_ARGS='-DRUNTIME_CHECK=asan -DCMAKE_C_FLAGS=-DQD_MEMORY_DEBUG -DQD_ENABLE_ASSERTIONS=ON -DDISPATCH_TEST_TIMEOUT=500'
   - name: "qdrouterd:RelWithDebInfo+MemoryDebug (clang on focal) on arm64"
@@ -135,6 +140,7 @@ jobs:
       - python3 -m pip install --user grpcio protobuf
     env:
       - QPID_SYSTEM_TEST_TIMEOUT=300
+      - QPID_SYSTEM_TEST_SKIP_FALLBACK_SWITCHOVER_TEST=True
       - CC=clang-11
       - CXX=clang++-11
       - PROTON_VERSION=main BUILD_TYPE=RelWithDebInfo
@@ -143,6 +149,7 @@ jobs:
     os: linux
     env:
     - QPID_SYSTEM_TEST_TIMEOUT=300
+    - QPID_SYSTEM_TEST_SKIP_FALLBACK_SWITCHOVER_TEST=True
     - PATH="/usr/bin:$PATH" PROTON_VERSION=0.35.0
   - name: "qdrouterd:TSAN"
     os: linux
@@ -160,6 +167,7 @@ jobs:
       - python -m pip install --user grpcio protobuf
     env:
     - QPID_SYSTEM_TEST_TIMEOUT=300
+    - QPID_SYSTEM_TEST_SKIP_FALLBACK_SWITCHOVER_TEST=True
     - PATH="/usr/bin:$PATH" PROTON_VERSION=0.35.0
     - DISPATCH_CMAKE_ARGS='-DRUNTIME_CHECK=tsan'
   - name: "qdrouterd:RelWithDebInfo+MemoryDebug (clang on macOS)"
@@ -167,6 +175,7 @@ jobs:
     osx_image: xcode11
     env:
     - QPID_SYSTEM_TEST_TIMEOUT=300
+    - QPID_SYSTEM_TEST_SKIP_FALLBACK_SWITCHOVER_TEST=True
     - PATH="/opt/local/bin:/opt/local/sbin:/usr/local/bin:$PATH" PROTON_VERSION=main
     - DISPATCH_CMAKE_ARGS='-DRUNTIME_CHECK=asan -DCMAKE_C_FLAGS=-DQD_MEMORY_DEBUG -DQD_ENABLE_ASSERTIONS=ON -DDISPATCH_TEST_TIMEOUT=500'
     # exclude tests that require raw_connection functionality; not available in libuv proactor
diff --git a/tests/system_tests_fallback_dest.py b/tests/system_tests_fallback_dest.py
index d34ea65..3ed1085 100644
--- a/tests/system_tests_fallback_dest.py
+++ b/tests/system_tests_fallback_dest.py
@@ -17,6 +17,8 @@
 # under the License.
 #
 
+import os
+
 from proton import Message, symbol
 from system_test import TestCase, Qdrouterd, main_module, TIMEOUT, TestTimeout
 from system_test import unittest
@@ -34,6 +36,14 @@ class AddrTimer(object):
         self.parent.check_address()
 
 
+def skip_switchover_tests():
+    skip_switchover_test = os.environ.get('QPID_SYSTEM_TEST_SKIP_FALLBACK_SWITCHOVER_TEST')
+    if skip_switchover_test is not None:
+        if skip_switchover_test.lower() in ['true', '1', 't', 'y', 'yes']:
+            return True
+    return False
+
+
 class RouterTest(TestCase):
 
     inter_router_port = None
@@ -49,8 +59,8 @@ class RouterTest(TestCase):
                 ('listener', {'port': cls.tester.get_port(), 'stripAnnotations': 'no'}),
                 ('listener', {'port': cls.tester.get_port(), 'role': 'route-container', 'name': 'WP'}),
                 ('address',  {'prefix': 'dest', 'enableFallback': 'yes'}),
-                ('autoLink', {'connection': 'WP', 'address': 'dest.al', 'dir': 'out', 'fallback': 'yes'}),
-                ('autoLink', {'connection': 'WP', 'address': 'dest.al', 'dir': 'in',  'fallback': 'yes'}),
+                ('autoLink', {'connection': 'WP', 'address': 'dest.al', 'direction': 'out', 'fallback': 'yes'}),
+                ('autoLink', {'connection': 'WP', 'address': 'dest.al', 'direction': 'in',  'fallback': 'yes'}),
                 connection
             ]
 
@@ -259,6 +269,9 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    skip_reason = 'Test skipped until switchover use case resolved'
+
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_25_switchover_same_edge(self):
         test = SwitchoverTest([self.ROUTER_EA1, "EA1"],
                               [self.ROUTER_EA1, "EA1"],
@@ -267,6 +280,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_26_switchover_same_interior(self):
         test = SwitchoverTest([self.ROUTER_INTA, "INTA"],
                               [self.ROUTER_INTA, "INTA"],
@@ -275,6 +289,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_27_switchover_local_edge_alt_remote_interior(self):
         test = SwitchoverTest([self.ROUTER_EA1, "EA1"],
                               [self.ROUTER_INTA, "INTA"],
@@ -283,6 +298,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_28_switchover_local_edge_alt_remote_edge(self):
         test = SwitchoverTest([self.ROUTER_EA1, "EA1"],
                               [self.ROUTER_EB1, "EB1"],
@@ -291,6 +307,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_29_switchover_local_edge_pri_remote_interior(self):
         test = SwitchoverTest([self.ROUTER_EA1, "EA1"],
                               [self.ROUTER_EA1, "EA1"],
@@ -299,6 +316,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_30_switchover_local_interior_pri_remote_edge(self):
         test = SwitchoverTest([self.ROUTER_EA1, "EA1"],
                               [self.ROUTER_EA1, "EA1"],
@@ -307,6 +325,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_31_switchover_local_interior_alt_remote_interior(self):
         test = SwitchoverTest([self.ROUTER_INTB, "INTB"],
                               [self.ROUTER_INTA, "INTA"],
@@ -315,6 +334,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_32_switchover_local_interior_alt_remote_edge(self):
         test = SwitchoverTest([self.ROUTER_INTB, "INTB"],
                               [self.ROUTER_EA2, "EA2"],
@@ -323,6 +343,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_33_switchover_local_interior_pri_remote_interior(self):
         test = SwitchoverTest([self.ROUTER_INTB, "INTB"],
                               [self.ROUTER_INTB, "INTB"],
@@ -331,6 +352,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_34_switchover_local_interior_pri_remote_edge(self):
         test = SwitchoverTest([self.ROUTER_INTB, "INTB"],
                               [self.ROUTER_INTB, "INTB"],
@@ -339,6 +361,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_35_switchover_mix_1(self):
         test = SwitchoverTest([self.ROUTER_INTA, "INTA"],
                               [self.ROUTER_INTB, "INTB"],
@@ -347,6 +370,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_36_switchover_mix_2(self):
         test = SwitchoverTest([self.ROUTER_EA1, "EA1"],
                               [self.ROUTER_INTB, "INTB"],
@@ -355,6 +379,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_37_switchover_mix_3(self):
         test = SwitchoverTest([self.ROUTER_EA1, "EA1"],
                               [self.ROUTER_INTB, "INTB"],
@@ -363,6 +388,7 @@ class RouterTest(TestCase):
         test.run()
         self.assertIsNone(test.error)
 
+    @unittest.skipIf(skip_switchover_tests(), skip_reason)
     def test_38_switchover_mix_4(self):
         test = SwitchoverTest([self.ROUTER_EA1, "EA1"],
                               [self.ROUTER_EA2, "EA2"],

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org