You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2024/01/07 02:16:00 UTC
[jira] [Commented] (HDFS-17327) Fix the judgment logic of the ReconfigurableBase class method reconfigureProperty.
[ https://issues.apache.org/jira/browse/HDFS-17327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803891#comment-17803891 ]
ASF GitHub Bot commented on HDFS-17327:
---------------------------------------
huangzhaobo99 commented on PR #6421:
URL: https://github.com/apache/hadoop/pull/6421#issuecomment-1879915837
Hi @ayushtkn If you have time, review the code logic.
Due to product design issues, a large number of UT do not match the actual situation.
If this logic is correct, I will fix the remaining UT according to the modified code logic.
> Fix the judgment logic of the ReconfigurableBase class method reconfigureProperty.
> ----------------------------------------------------------------------------------
>
> Key: HDFS-17327
> URL: https://issues.apache.org/jira/browse/HDFS-17327
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: huangzhaobo
> Assignee: huangzhaobo
> Priority: Blocker
> Labels: pull-request-available
>
> 1. If it is a null value, after reconfig, the current system value will take effect and not necessarily the default value.
> 2. {{ReconfigurableBase#reconfigureProperty}} judges the condition incorrectly, When the effectValue is not null, the system value needs to be changed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org