You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/28 19:03:07 UTC

[GitHub] [airflow] mik-laj opened a new issue #9558: Missing operator - CloudVisionReferenceImageCreateOperator

mik-laj opened a new issue #9558:
URL: https://github.com/apache/airflow/issues/9558


   Hello,
   
   We miss the operator for method delete_reference_image to hook CloudVisionHook. All other methods probably have matching operators.
   This is important to me because the handle method refers to this operator in docstring.
   https://github.com/apache/airflow/blob/1d36b0303b8632fce6de78ca4e782ae26ee06fea/airflow/providers/google/cloud/hooks/vision.py#L428
   
   Best regards,
   Kamil


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] subkanthi commented on issue #9558: Missing operator - CloudVisionReferenceImageCreateOperator

Posted by GitBox <gi...@apache.org>.
subkanthi commented on issue #9558:
URL: https://github.com/apache/airflow/issues/9558#issuecomment-653911804


   Looks like already implemented. @mik-laj 
   
   `@GoogleBaseHook.fallback_to_default_project_id
       def delete_reference_image(
           self,
           location: str,
           product_id: str,
           reference_image_id: str,
           project_id: str,
           retry: Optional[Retry] = None,
           timeout: Optional[float] = None,
           metadata: Optional[Sequence[Tuple[str, str]]] = None,
       ) -> Dict:`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj closed issue #9558: Missing operator - CloudVisionReferenceImageCreateOperator

Posted by GitBox <gi...@apache.org>.
mik-laj closed issue #9558:
URL: https://github.com/apache/airflow/issues/9558


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #9558: Missing operator - CloudVisionReferenceImageCreateOperator

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #9558:
URL: https://github.com/apache/airflow/issues/9558#issuecomment-654334121


   Go for it @manesioz !
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on issue #9558: Missing operator - CloudVisionReferenceImageCreateOperator

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #9558:
URL: https://github.com/apache/airflow/issues/9558#issuecomment-653912612


   @subkanthi  we have method in hook, but we don't have an operator that allows us to easily use this method in DAG.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] manesioz commented on issue #9558: Missing operator - CloudVisionReferenceImageCreateOperator

Posted by GitBox <gi...@apache.org>.
manesioz commented on issue #9558:
URL: https://github.com/apache/airflow/issues/9558#issuecomment-654301476


   I'd like to take a stab at it if no one else is working on it. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org