You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/10 00:54:01 UTC

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4694: Add groupByMode=sql and responseFormat=sql options to query console

kishoreg commented on a change in pull request #4694: Add groupByMode=sql and responseFormat=sql options to query console
URL: https://github.com/apache/incubator-pinot/pull/4694#discussion_r333291420
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PqlQueryResource.java
 ##########
 @@ -76,8 +76,12 @@ public String post(String requestJsonStr, @Context HttpHeaders httpHeaders) {
       if (requestJson.has("trace")) {
         traceEnabled = requestJson.get("trace").toString();
       }
+      String queryOptions = null;
+      if (requestJson.has("queryOptions")) {
+        queryOptions = requestJson.get("queryOptions").asText();
+      }
       LOGGER.debug("Trace: {}, Running query: {}", traceEnabled, pqlQuery);
-      return getQueryResponse(pqlQuery, traceEnabled, httpHeaders);
+      return getQueryResponse(pqlQuery, traceEnabled, queryOptions, httpHeaders);
 
 Review comment:
   traceEnabled can also be part of queryOptions rt

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org