You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/07 13:57:43 UTC
[GitHub] [tvm] gigiblender opened a new issue, #12335: [CI Problem] Deduplicate the `retry` function from the Jenkinsfile
gigiblender opened a new issue, #12335:
URL: https://github.com/apache/tvm/issues/12335
I am wondering if it's possible to duplicate the `retry` function from the Jenkinsfile. This increases quite a bit the size of our Jenkinsfile. I was thinking about something similar to what is done in #12291.
The drawback is that we could no longer test it with the Jenkinsfile linter.
Thoughts @driazati @areusch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati closed issue #12335: [CI Problem] Deduplicate the `retry` function from the Jenkinsfile
Posted by GitBox <gi...@apache.org>.
driazati closed issue #12335: [CI Problem] Deduplicate the `retry` function from the Jenkinsfile
URL: https://github.com/apache/tvm/issues/12335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on issue #12335: [CI Problem] Deduplicate the `retry` function from the Jenkinsfile
Posted by GitBox <gi...@apache.org>.
driazati commented on issue #12335:
URL: https://github.com/apache/tvm/issues/12335#issuecomment-1208362322
This would be nice (and we could do something similar to de-duplicate some other inlined code) but I think we'll need to re-implement some of the Jenkins trust mechanism first since it'd be pretty trivial for anyone to then mess with the CI runners (i.e. if a PR is not from a trusted user then we use the versions of files X Y and Z from the base commit and not from the PR HEAD, similar to how the `Jenkinsfile` works) with a test like
```
trusted = false
if env.BRANCH_NAME.startswith("PR-"):
if env.CHANGE_AUTHOR in `CONTRIBUTORS.md:
trusted = true
else:
trusted = true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on issue #12335: [CI Problem] Deduplicate the `retry` function from the Jenkinsfile
Posted by GitBox <gi...@apache.org>.
driazati commented on issue #12335:
URL: https://github.com/apache/tvm/issues/12335#issuecomment-1317710480
This is implemented now in https://github.com/apache/tvm/blob/main/ci/scripts/jenkins/retry.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org