[GitHub] [mynewt-core] utzig commented on a change in pull request #2467: [KINETIS] mcu/nxp: adding K8xF support. hw/bsp: adding frdm-k82f BSP

[GitBox <gi...@apache.org>]

utzig commented on a change in pull request #2467:
URL: https://github.com/apache/mynewt-core/pull/2467#discussion_r570888242



##########
File path: .rat-excludes
##########
@@ -291,6 +291,15 @@ fsl_clock.c
 MK64FN1M0xxx12_flash.ld
 boot-MK64FN1M0xxx12_flash.ld
 startup_MK64F12.S
+MK82FN256xxx15_flash.ld
+boot-MK82FN256xxx15_flash.ld
+startup_MK82F25615.S
+MK82F25615.h
+MK82F25615_features.h
+system_MK82F25615.h
+system_MK82F25615.c
+fsl_clock.h
+

Review comment:
       Remove the empty line.

##########
File path: hw/mcu/nxp/kinetis/MK64F12/pkg.yml
##########
@@ -23,6 +23,4 @@ pkg.author: "Apache Mynewt <de...@mynewt.apache.org>"
 pkg.homepage: "http://mynewt.apache.org/"
 
 pkg.deps:
-    - "@apache-mynewt-core/hw/hal"
-    - "@apache-mynewt-core/hw/cmsis-core"

Review comment:
       Unrelated to K8x, move into another commit with rationale.

##########
File path: hw/mcu/nxp/kinetis/MK64F12/syscfg.yml
##########
@@ -17,3 +17,4 @@
 #
 syscfg.vals:
     OS_TICKS_PER_SEC: 1000
+    MCU_FLASH_MIN_WRITE_SIZE: 2

Review comment:
       Move K6x changes into another commit.

##########
File path: hw/mcu/nxp/kinetis/MK8xF/include/mcu/frdm-k8xf_hal.h
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#ifndef __MCU_FRDMK8XF_BSP_H_
+#define __MCU_FRDMK8XF_BSP_H_
+
+#ifdef __cplusplus
+ extern "C" {
+#endif
+
+struct hal_flash;
+extern const struct hal_flash kinetis_flash_dev;
+extern const struct hal_flash nxp_qspi_dev;
+
+struct nxp_hal_i2c_cfg {
+    int8_t pin_scl;
+    int8_t pin_sda;
+    uint32_t frequency;
+};
+
+struct nxp_hal_spi_cfg {
+    uint32_t clk_pin;
+    uint32_t pcs_pin;
+    uint32_t sout_pin;
+    uint32_t sin_pin;
+};

Review comment:
       Why are `nxp_hal_i2c_cfg` and `nxp_hal_spi_cfg` redefined here if they are already in `mcu/kinetis_hal.h`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org