You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/08/28 00:50:18 UTC

Review Request 25126: Fixed signal handling for stout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25126/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos-git


Description
-------

Moved back installSignalHandler to src/logging.cpp in mesos, because it's no longer used by anyone else.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am b18dbd3adb43581783121c52effac179423755f9 
  3rdparty/libprocess/3rdparty/stout/include/stout/glog.hpp cec7f4d3fd7c6e69c1d9aa43dcc62ddd6838e5d4 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp f32130acd2aa3c34876a929a77ef274218be0e89 
  3rdparty/libprocess/3rdparty/stout/tests/main.cpp fa8093b1007e04fa5eee14bfe434be1dc30dd670 

Diff: https://reviews.apache.org/r/25126/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request 25126: Fixed signal handling for stout.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25126/#review51714
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Aug. 27, 2014, 10:50 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25126/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 10:50 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Moved back installSignalHandler to src/logging.cpp in mesos, because it's no longer used by anyone else.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am b18dbd3adb43581783121c52effac179423755f9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/glog.hpp cec7f4d3fd7c6e69c1d9aa43dcc62ddd6838e5d4 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp f32130acd2aa3c34876a929a77ef274218be0e89 
>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp fa8093b1007e04fa5eee14bfe434be1dc30dd670 
> 
> Diff: https://reviews.apache.org/r/25126/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>