You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Matthias Wronka (JIRA)" <de...@myfaces.apache.org> on 2007/05/10 16:15:15 UTC

[jira] Created: (TOBAGO-396) component-height-calculation-problem

component-height-calculation-problem
------------------------------------

                 Key: TOBAGO-396
                 URL: https://issues.apache.org/jira/browse/TOBAGO-396
             Project: MyFaces Tobago
          Issue Type: Bug
            Reporter: Matthias Wronka


Consider the following jsp-code. It contains two panels (one in another). The inner panel contains 4 rows of which the two in the middle are set to rendered=false.

<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
<%@ taglib uri="http://myfaces.apache.org/tobago/component" prefix="tc"%>
<%@ taglib uri="http://myfaces.apache.org/tobago/extension" prefix="tx"%>

<f:view>
	<tc:page id="edit" state="#{screenSizeBean}"
		width="#{screenSizeBean.clientWidth}" height="#{screenSizeBean.clientHeight}"
		label="#{appBundle.application}">


		<%-- content --%>
		<tc:panel>
			<f:facet name="layout">
				<tc:gridLayout columns="*" rows="*" margin="10px" border="0"/>
			</f:facet>
			
			<tc:box label="Detailansicht">
				<f:facet name="layout">
					<tc:gridLayout rows="fixed;*" border="0"/>
				</f:facet>
				
				<tc:panel>
					<f:facet name="layout">
						<tc:gridLayout rows="fixed;fixed;fixed;fixed" columns="2*;60px;3*;40px" border="0" />
					</f:facet>
						<%-- row 1 --%>						
              			<tx:in value="12" required="false" readonly="true" label="Zeile 1" tip="Bereitstellungszinsen" markup="number">			
											</tx:in>
						<tc:label value="%" />
						<tx:in value="12.10.2006" required="false" readonly="true" label="Bereitstellungszinsen ab" tip="Bereitstellungszinsen ab"/>
						<tc:cell/> 
              			<%-- row 2 --%>             			
              			<tx:in value="12" required="false" readonly="true" label="Zeile 2" rendered="false" markup="number">			
							<f:validateLength maximum="3" />
							<f:validateLongRange minimum="0"/>
						</tx:in>
						<tc:label value="Mon." rendered="false"/>
              			<tc:cell spanX="2" rendered="false"/>     
              			<%-- row 3 --%>
              			<tx:in value="12" required="false" readonly="true" label="Zeile 3" rendered="false" markup="number">			
							<f:validateLength maximum="3" />
							<f:validateLongRange minimum="0"/>
						</tx:in>
						<tc:label value="Mon." rendered="false"/>
              			<tc:cell spanX="2" rendered="false"/>    
              			<%-- row 4 --%>
              			<tx:in value="12" required="false" readonly="true" label="Zeile 4" tip="Bereitstellungszinsen" markup="number">			
													</tx:in>
						<tc:label value="%" />
						<tx:in value="12.11.2006" required="false" readonly="true" label="Bereitstellungszinsen ab" tip="Bereitstellungszinsen ab"/>
						<tc:cell/> 
				</tc:panel>
				<tc:cell/>
			</tc:box>
		</tc:panel>
	</tc:page>
</f:view>

The resulting output cuts off the lower half of the fourth row (see sreenshot). If you change the layout-definition of the inner panel to

<f:facet name="layout">
	<tc:gridLayout rows="20px;fixed;fixed;fixed" columns="2*;60px;3*;40px" border="0" />
</f:facet>

Everything looks fine (see other screenshot). The interesting thing is, that our theme defines Tobago.fixedHeight=20 in tobago-theme-config.properties.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TOBAGO-396) component-height-calculation-problem

Posted by "Volker Weber (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOBAGO-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Volker Weber resolved TOBAGO-396.
---------------------------------

    Resolution: Fixed

> component-height-calculation-problem
> ------------------------------------
>
>                 Key: TOBAGO-396
>                 URL: https://issues.apache.org/jira/browse/TOBAGO-396
>             Project: MyFaces Tobago
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.10
>            Reporter: Matthias Wronka
>         Assigned To: Volker Weber
>             Fix For: 1.0.11
>
>         Attachments: screenshot-1.jpg, screenshot-2.jpg
>
>
> Consider the following jsp-code. It contains two panels (one in another). The inner panel contains 4 rows of which the two in the middle are set to rendered=false.
> <%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
> <%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
> <%@ taglib uri="http://myfaces.apache.org/tobago/component" prefix="tc"%>
> <%@ taglib uri="http://myfaces.apache.org/tobago/extension" prefix="tx"%>
> <f:view>
> 	<tc:page id="edit" state="#{screenSizeBean}"
> 		width="#{screenSizeBean.clientWidth}" height="#{screenSizeBean.clientHeight}"
> 		label="#{appBundle.application}">
> 		<%-- content --%>
> 		<tc:panel>
> 			<f:facet name="layout">
> 				<tc:gridLayout columns="*" rows="*" margin="10px" border="0"/>
> 			</f:facet>
> 			
> 			<tc:box label="Detailansicht">
> 				<f:facet name="layout">
> 					<tc:gridLayout rows="fixed;*" border="0"/>
> 				</f:facet>
> 				
> 				<tc:panel>
> 					<f:facet name="layout">
> 						<tc:gridLayout rows="fixed;fixed;fixed;fixed" columns="2*;60px;3*;40px" border="0" />
> 					</f:facet>
> 						<%-- row 1 --%>						
>               			<tx:in value="12" required="false" readonly="true" label="Zeile 1" tip="Bereitstellungszinsen" markup="number">			
> 											</tx:in>
> 						<tc:label value="%" />
> 						<tx:in value="12.10.2006" required="false" readonly="true" label="Bereitstellungszinsen ab" tip="Bereitstellungszinsen ab"/>
> 						<tc:cell/> 
>               			<%-- row 2 --%>             			
>               			<tx:in value="12" required="false" readonly="true" label="Zeile 2" rendered="false" markup="number">			
> 							<f:validateLength maximum="3" />
> 							<f:validateLongRange minimum="0"/>
> 						</tx:in>
> 						<tc:label value="Mon." rendered="false"/>
>               			<tc:cell spanX="2" rendered="false"/>     
>               			<%-- row 3 --%>
>               			<tx:in value="12" required="false" readonly="true" label="Zeile 3" rendered="false" markup="number">			
> 							<f:validateLength maximum="3" />
> 							<f:validateLongRange minimum="0"/>
> 						</tx:in>
> 						<tc:label value="Mon." rendered="false"/>
>               			<tc:cell spanX="2" rendered="false"/>    
>               			<%-- row 4 --%>
>               			<tx:in value="12" required="false" readonly="true" label="Zeile 4" tip="Bereitstellungszinsen" markup="number">			
> 													</tx:in>
> 						<tc:label value="%" />
> 						<tx:in value="12.11.2006" required="false" readonly="true" label="Bereitstellungszinsen ab" tip="Bereitstellungszinsen ab"/>
> 						<tc:cell/> 
> 				</tc:panel>
> 				<tc:cell/>
> 			</tc:box>
> 		</tc:panel>
> 	</tc:page>
> </f:view>
> The resulting output cuts off the lower half of the fourth row (see sreenshot). If you change the layout-definition of the inner panel to
> <f:facet name="layout">
> 	<tc:gridLayout rows="20px;fixed;fixed;fixed" columns="2*;60px;3*;40px" border="0" />
> </f:facet>
> Everything looks fine (see other screenshot). The interesting thing is, that our theme defines Tobago.fixedHeight=20 in tobago-theme-config.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.