You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Joris van Lieshout <jv...@schubergphilis.com> on 2014/05/21 15:56:45 UTC

Review Request 21769: blacklisting pcspkr as cosmetic improvement. fixing aesni_intel blacklisting because modprobe.d files have to end with .conf

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21769/
-----------------------------------------------------------

Review request for cloudstack and daan Hoogland.


Repository: cloudstack-git


Description
-------

the blacklisting of aesni_intel was not working. the file has to end with .conf. blacklisting pcspkr as cosmetic improvement.


Diffs
-----

  systemvm/patches/debian/config/etc/modprobe.d/aesni_intel 1c140f0 
  systemvm/patches/debian/config/etc/modprobe.d/aesni_intel.conf PRE-CREATION 
  systemvm/patches/debian/config/etc/modprobe.d/pcspkr.conf PRE-CREATION 

Diff: https://reviews.apache.org/r/21769/diff/


Testing
-------

running in our own production environment on many svms for a while now


Thanks,

Joris van Lieshout


Re: Review Request 21769: blacklisting pcspkr as cosmetic improvement. fixing aesni_intel blacklisting because modprobe.d files have to end with .conf

Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21769/#review45228
-----------------------------------------------------------

Ship it!


11f532bbecca08b41dd15d1abdf04957c84eebda

- daan Hoogland


On May 21, 2014, 1:56 p.m., Joris van Lieshout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21769/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 1:56 p.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> the blacklisting of aesni_intel was not working. the file has to end with .conf. blacklisting pcspkr as cosmetic improvement.
> 
> 
> Diffs
> -----
> 
>   systemvm/patches/debian/config/etc/modprobe.d/aesni_intel 1c140f0 
>   systemvm/patches/debian/config/etc/modprobe.d/aesni_intel.conf PRE-CREATION 
>   systemvm/patches/debian/config/etc/modprobe.d/pcspkr.conf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/21769/diff/
> 
> 
> Testing
> -------
> 
> running in our own production environment on many svms for a while now
> 
> 
> Thanks,
> 
> Joris van Lieshout
> 
>