You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by fe...@apache.org on 2011/08/14 15:41:16 UTC
svn commit: r1157530 -
/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/FileItemRegistry.java
Author: felixk
Date: Sun Aug 14 13:41:16 2011
New Revision: 1157530
URL: http://svn.apache.org/viewvc?rev=1157530&view=rev
Log:
FileItem is incompatible with expected argument type String. As no return value is validated we will never notice if the item has been removed ... or if just 'null' has been returned
Modified:
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/FileItemRegistry.java
Modified: james/hupa/trunk/server/src/main/java/org/apache/hupa/server/FileItemRegistry.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/FileItemRegistry.java?rev=1157530&r1=1157529&r2=1157530&view=diff
==============================================================================
--- james/hupa/trunk/server/src/main/java/org/apache/hupa/server/FileItemRegistry.java (original)
+++ james/hupa/trunk/server/src/main/java/org/apache/hupa/server/FileItemRegistry.java Sun Aug 14 13:41:16 2011
@@ -58,7 +58,7 @@ public class FileItemRegistry {
public void remove(FileItem item) {
if (item != null) {
logger.debug("Remove item " + item.getName() + " with name " + item.getFieldName());
- map.remove(item);
+ map.remove(item.getFieldName());
// Remove temporary stuff
item.delete();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org