[GitHub] [hbase] saintstack commented on a change in pull request #1259: HBASE-23951: Avoid high speed recursion trap in AsyncRequestFutureImpl.

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #1259: HBASE-23951: Avoid high speed recursion trap in AsyncRequestFutureImpl.
URL: https://github.com/apache/hbase/pull/1259#discussion_r396661168
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java
 ##########
 @@ -747,9 +771,9 @@ private void resubmit(ServerName oldServer, List<Action> toReplay,
     // It should be possible to have some heuristics to take the right decision. Short term,
     //  we go for one.
     boolean retryImmediately = throwable instanceof RetryImmediatelyException;
-    int nextAttemptNumber = retryImmediately ? numAttempt : numAttempt + 1;
+    int nextAttemptNumber = numAttempt + 1;
 
 Review comment:
   How does this change our behavior @markrmiller 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services