You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Shkvyra <ds...@gmail.com> on 2014/01/15 20:57:28 UTC
Review Request 16915: Agent should ensure that the path for mapred.hosts and
mapred.hosts.exclude is present
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
Summary (updated)
-----------------
Agent should ensure that the path for mapred.hosts and mapred.hosts.exclude is present
Bugs: AMBARI-4305
https://issues.apache.org/jira/browse/AMBARI-4305
Repository: ambari
Description (updated)
-------
Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet (for old versions)
Diffs (updated)
-----
ambari-agent/src/main/puppet/modules/hdp-hadoop/manifests/init.pp 8389bd2
ambari-agent/src/main/puppet/modules/hdp-hadoop/manifests/params.pp 5b9ebaa
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py 41e2af1
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py 55f4303
Diff: https://reviews.apache.org/r/16915/diff/
Testing (updated)
-------
Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
Predefined files were not overriden and not existed files were created.
Thanks,
Dmytro Shkvyra
Re: Review Request 16915: Agent should ensure that the path for mapred.hosts
and mapred.hosts.exclude is present
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/#review31915
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 15, 2014, 7:57 p.m., Dmytro Shkvyra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16915/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 7:57 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4305
> https://issues.apache.org/jira/browse/AMBARI-4305
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet (for old versions)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/puppet/modules/hdp-hadoop/manifests/init.pp 8389bd2
> ambari-agent/src/main/puppet/modules/hdp-hadoop/manifests/params.pp 5b9ebaa
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py 41e2af1
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py 55f4303
>
> Diff: https://reviews.apache.org/r/16915/diff/
>
>
> Testing
> -------
>
> Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
> Predefined files were not overriden and not existed files were created.
>
>
> Thanks,
>
> Dmytro Shkvyra
>
>
Re: Review Request 16915: Agent should ensure that the path for mapred.hosts
and mapred.hosts.exclude is present
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/#review31920
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py
<https://reviews.apache.org/r/16915/#comment60675>
Can we start adding unit tests for service specific scripts? Dmytro can you add one?
- Mahadev Konar
On Jan. 15, 2014, 7:57 p.m., Dmytro Shkvyra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16915/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 7:57 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4305
> https://issues.apache.org/jira/browse/AMBARI-4305
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet (for old versions)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/puppet/modules/hdp-hadoop/manifests/init.pp 8389bd2
> ambari-agent/src/main/puppet/modules/hdp-hadoop/manifests/params.pp 5b9ebaa
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py 41e2af1
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py 55f4303
>
> Diff: https://reviews.apache.org/r/16915/diff/
>
>
> Testing
> -------
>
> Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
> Predefined files were not overriden and not existed files were created.
>
>
> Thanks,
>
> Dmytro Shkvyra
>
>
Re: Review Request 16915: Agent should ensure that the path for mapred.hosts
and mapred.hosts.exclude is present
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/#review32073
-----------------------------------------------------------
Ship it!
As of now, we have no infrastructure for running unit tests of service scripts at ambari-server (troubles with imports and PYTHONPATH).
Patch looks good to me.
- Dmitro Lisnichenko
On Jan. 16, 2014, 8:53 p.m., Dmytro Shkvyra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16915/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2014, 8:53 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4305
> https://issues.apache.org/jira/browse/AMBARI-4305
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet (for old versions)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py 41e2af1
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py 55f4303
>
> Diff: https://reviews.apache.org/r/16915/diff/
>
>
> Testing
> -------
>
> Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
> Predefined files were not overriden and not existed files were created.
>
>
> Thanks,
>
> Dmytro Shkvyra
>
>
Re: Review Request 16915: Agent should ensure that the path for mapred.hosts
and mapred.hosts.exclude is present
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 8:53 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
Changes
-------
Remove unitest
Bugs: AMBARI-4305
https://issues.apache.org/jira/browse/AMBARI-4305
Repository: ambari
Description
-------
Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet (for old versions)
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py 41e2af1
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py 55f4303
Diff: https://reviews.apache.org/r/16915/diff/
Testing
-------
Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
Predefined files were not overriden and not existed files were created.
Thanks,
Dmytro Shkvyra
Re: Review Request 16915: Agent should ensure that the path for mapred.hosts
and mapred.hosts.exclude is present
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 8:17 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
Changes
-------
Remove test method
Bugs: AMBARI-4305
https://issues.apache.org/jira/browse/AMBARI-4305
Repository: ambari
Description
-------
Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet (for old versions)
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py 41e2af1
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py 55f4303
Diff: https://reviews.apache.org/r/16915/diff/
Testing
-------
Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
Predefined files were not overriden and not existed files were created.
Thanks,
Dmytro Shkvyra
Re: Review Request 16915: Agent should ensure that the path for mapred.hosts
and mapred.hosts.exclude is present
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/
-----------------------------------------------------------
(Updated Jan. 16, 2014, 6:32 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
Changes
-------
I have removed puppet support and added unitest for mapreduce.py I have imported modules by path, because we can have different modules with same name (different stacks - for example)
Bugs: AMBARI-4305
https://issues.apache.org/jira/browse/AMBARI-4305
Repository: ambari
Description
-------
Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet (for old versions)
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py 41e2af1
ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py 55f4303
ambari-server/src/test/python/TestHDP_services_Mapreduce.py PRE-CREATION
Diff: https://reviews.apache.org/r/16915/diff/
Testing
-------
Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
Predefined files were not overriden and not existed files were created.
Thanks,
Dmytro Shkvyra
Re: Review Request 16915: Agent should ensure that the path for mapred.hosts
and mapred.hosts.exclude is present
Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16915/#review31919
-----------------------------------------------------------
ambari-agent/src/main/puppet/modules/hdp-hadoop/manifests/init.pp
<https://reviews.apache.org/r/16915/#comment60674>
We dont need to make puppet changes since we are removing usage of puppet by next week.
- Mahadev Konar
On Jan. 15, 2014, 7:57 p.m., Dmytro Shkvyra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16915/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2014, 7:57 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
>
>
> Bugs: AMBARI-4305
> https://issues.apache.org/jira/browse/AMBARI-4305
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add checking and creation of mapred.hosts and mapred.hosts.exclude files by python and puppet (for old versions)
>
>
> Diffs
> -----
>
> ambari-agent/src/main/puppet/modules/hdp-hadoop/manifests/init.pp 8389bd2
> ambari-agent/src/main/puppet/modules/hdp-hadoop/manifests/params.pp 5b9ebaa
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/mapreduce.py 41e2af1
> ambari-server/src/main/resources/stacks/HDP/1.3.4/services/MAPREDUCE/package/scripts/params.py 55f4303
>
> Diff: https://reviews.apache.org/r/16915/diff/
>
>
> Testing
> -------
>
> Tested on Centos6 /HDP-1.3.3 and HDP-1.3.4
> Predefined files were not overriden and not existed files were created.
>
>
> Thanks,
>
> Dmytro Shkvyra
>
>