You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Dominic Hamon (JIRA)" <ji...@apache.org> on 2014/03/05 20:18:44 UTC

[jira] [Comment Edited] (MESOS-1023) Replace all static/global variables with non-POD type

    [ https://issues.apache.org/jira/browse/MESOS-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921158#comment-13921158 ] 

Dominic Hamon edited comment on MESOS-1023 at 3/5/14 7:17 PM:
--------------------------------------------------------------

Next phase: Replacing HELP strings with static methods that use process::HELP to build strings when called.

https://reviews.apache.org/r/18784/
https://reviews.apache.org/r/18785/


was (Author: dhamon):
Next phase: Replacing HELP strings with static methods that use process::HELP to build strings when called.

> Replace all static/global variables with non-POD type
> -----------------------------------------------------
>
>                 Key: MESOS-1023
>                 URL: https://issues.apache.org/jira/browse/MESOS-1023
>             Project: Mesos
>          Issue Type: Bug
>          Components: general
>            Reporter: Dominic Hamon
>            Assignee: Dominic Hamon
>              Labels: c++
>             Fix For: 0.19.0
>
>
> See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Static_and_Global_Variables for the background.
> Real bugs have been seen. For example, in process::ID::generate we have a map<string, int> that can be accessed within the function after exit has been called. Ie, we can try to access the map after it's been destroyed, but before exit has completed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)