[GitHub] ivankelly opened a new pull request #930: [WIP] Issue #903: Bc tests based on docker

[GitBox <gi...@apache.org>]

ivankelly opened a new pull request #930: [WIP] Issue #903: Bc tests based on docker
URL: https://github.com/apache/bookkeeper/pull/930
 
 
   This is a work in progress, but I'd like some feedback/opinions before cleaning it up.
   
   The basis idea is to generate a proxy server for each client version. Each proxy runs in its own container, and has a completely isolated classpath. The client is compiled against a single version of BK (4.2.0), so if we have a binary break, we should catch it by just using the proxy. This should be tested separately though. The proxy server/client is GRpc based.
   
   I've converted one test to show what it looks like in usage. Really, this test needs to be broken down into smaller tests, it's a beast right now. This all needs a lot of cleanup.
   
   I'm not sure we should use arquillian. It doesn't seem to add much. For all the interesting stuff I find myself dropping out to using the docker client directly. Arquillian basically just provides something like docker-compose, but even then, it's a bit limited.  The documentation is not very good (there's a lot of it, but it reads like a novel, and there's no javadoc). It doesn't seem to allow you to dump the logs from the containers at the end of a run. I think we'd be more productive just using docker-client directly.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services