[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #7713: Spark 3.3,3.4: Add back log making it clearer when we are not pushing down filters

["aokolnychyi (via GitHub)" <gi...@apache.org>]

aokolnychyi commented on code in PR #7713:
URL: https://github.com/apache/iceberg/pull/7713#discussion_r1207175005


##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -171,7 +171,10 @@ public Filter[] pushFilters(Filter[] filters) {
         }
 
       } catch (Exception e) {
-        LOG.warn("Failed to check if {} can be pushed down: {}", filter, e.getMessage());

Review Comment:
   I thought you wanted to log a message when a filter could not be converted above. This block is only for abnormal cases. I also wonder whether we should include the actual exception together with the trace. I kept the old logic when I touched it but I am not sure why we did not want to include a trace in the first place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org