You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/03/07 09:29:18 UTC
Re: Review Request 44415: LENS-983 : Make default response type as
XML on all resources
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44415/
-----------------------------------------------------------
(Updated March 7, 2016, 8:29 a.m.)
Review request for lens.
Changes
-------
Updated MediaType.APPLICATION_XML to be default on all resources
Summary (updated)
-----------------
LENS-983 : Make default response type as XML on all resources
Bugs: LENS-983
https://issues.apache.org/jira/browse/LENS-983
Repository: lens
Description
-------
Changed all response type order.
Added unit test to verify default type for session resource
Diffs (updated)
-----
lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 53bac7d
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 6e1a709
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 6ee1e34
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 568b416
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java faaf172
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 424bd87
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java f38e70d
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java e54f0af
Diff: https://reviews.apache.org/r/44415/diff/
Testing
-------
INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.927s]
[INFO] Lens .............................................. SUCCESS [3.689s]
[INFO] Lens API .......................................... SUCCESS [27.397s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.915s]
[INFO] Lens Cube ......................................... SUCCESS [11:09.116s]
[INFO] Lens DB storage ................................... SUCCESS [20.530s]
[INFO] Lens Query Library ................................ SUCCESS [16.930s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:04.066s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.248s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [18.084s]
[INFO] Lens Server ....................................... SUCCESS [16:10.023s]
[INFO] Lens client ....................................... SUCCESS [35.842s]
[INFO] Lens CLI .......................................... SUCCESS [2:40.286s]
[INFO] Lens Examples ..................................... SUCCESS [10.930s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.745s]
[INFO] Lens Distribution ................................. SUCCESS [9.580s]
[INFO] Lens ML Lib ....................................... FAILURE [40:03.571s]
[INFO] Lens ML Ext Distribution .......................... SKIPPED
[INFO] Lens Regression ................................... SKIPPED
[INFO] Lens UI ........................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
ML Lib failed because of https://issues.apache.org/jira/browse/LENS-982
Thanks,
Amareshwari Sriramadasu
Re: Review Request 44415: LENS-983 : Make default response type as
XML on all resources
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44415/#review122475
-----------------------------------------------------------
Ship it!
Ship It!
- Raju Bairishetti
On March 7, 2016, 8:29 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44415/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 8:29 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-983
> https://issues.apache.org/jira/browse/LENS-983
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changed all response type order.
> Added unit test to verify default type for session resource
>
>
> Diffs
> -----
>
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 53bac7d
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 6e1a709
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 6ee1e34
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 568b416
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java faaf172
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 424bd87
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java f38e70d
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java e54f0af
>
> Diff: https://reviews.apache.org/r/44415/diff/
>
>
> Testing
> -------
>
> INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.927s]
> [INFO] Lens .............................................. SUCCESS [3.689s]
> [INFO] Lens API .......................................... SUCCESS [27.397s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.915s]
> [INFO] Lens Cube ......................................... SUCCESS [11:09.116s]
> [INFO] Lens DB storage ................................... SUCCESS [20.530s]
> [INFO] Lens Query Library ................................ SUCCESS [16.930s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:04.066s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.248s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.084s]
> [INFO] Lens Server ....................................... SUCCESS [16:10.023s]
> [INFO] Lens client ....................................... SUCCESS [35.842s]
> [INFO] Lens CLI .......................................... SUCCESS [2:40.286s]
> [INFO] Lens Examples ..................................... SUCCESS [10.930s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.745s]
> [INFO] Lens Distribution ................................. SUCCESS [9.580s]
> [INFO] Lens ML Lib ....................................... FAILURE [40:03.571s]
> [INFO] Lens ML Ext Distribution .......................... SKIPPED
> [INFO] Lens Regression ................................... SKIPPED
> [INFO] Lens UI ........................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
>
> ML Lib failed because of https://issues.apache.org/jira/browse/LENS-982
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 44415: LENS-983 : Make default response type as
XML on all resources
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 7, 2016, 11:51 a.m., Raju Bairishetti wrote:
> > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java, line 114
> > <https://reviews.apache.org/r/44415/diff/2/?file=1282386#file1282386line114>
> >
> > Can we use dataprovider for MediaType here?
Test is for default type. Cannnot be a data provider test.
> On March 7, 2016, 11:51 a.m., Raju Bairishetti wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java, line 250
> > <https://reviews.apache.org/r/44415/diff/2/?file=1282381#file1282381line250>
> >
> > Are we not supporting MediaType.TEXT_PLAIN any more for this?
LensAPIResult is a complex object and producing TEXT_PLAIN should be done for String objects. So, removed.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44415/#review122289
-----------------------------------------------------------
On March 7, 2016, 8:29 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44415/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 8:29 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-983
> https://issues.apache.org/jira/browse/LENS-983
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changed all response type order.
> Added unit test to verify default type for session resource
>
>
> Diffs
> -----
>
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 53bac7d
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 6e1a709
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 6ee1e34
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 568b416
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java faaf172
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 424bd87
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java f38e70d
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java e54f0af
>
> Diff: https://reviews.apache.org/r/44415/diff/
>
>
> Testing
> -------
>
> INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.927s]
> [INFO] Lens .............................................. SUCCESS [3.689s]
> [INFO] Lens API .......................................... SUCCESS [27.397s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.915s]
> [INFO] Lens Cube ......................................... SUCCESS [11:09.116s]
> [INFO] Lens DB storage ................................... SUCCESS [20.530s]
> [INFO] Lens Query Library ................................ SUCCESS [16.930s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:04.066s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.248s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.084s]
> [INFO] Lens Server ....................................... SUCCESS [16:10.023s]
> [INFO] Lens client ....................................... SUCCESS [35.842s]
> [INFO] Lens CLI .......................................... SUCCESS [2:40.286s]
> [INFO] Lens Examples ..................................... SUCCESS [10.930s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.745s]
> [INFO] Lens Distribution ................................. SUCCESS [9.580s]
> [INFO] Lens ML Lib ....................................... FAILURE [40:03.571s]
> [INFO] Lens ML Ext Distribution .......................... SKIPPED
> [INFO] Lens Regression ................................... SKIPPED
> [INFO] Lens UI ........................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
>
> ML Lib failed because of https://issues.apache.org/jira/browse/LENS-982
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 44415: LENS-983 : Make default response type as
XML on all resources
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44415/#review122289
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
<https://reviews.apache.org/r/44415/#comment184248>
Are we not supporting MediaType.TEXT_PLAIN any more for this?
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java (line 114)
<https://reviews.apache.org/r/44415/#comment184249>
Can we use dataprovider for MediaType here?
- Raju Bairishetti
On March 7, 2016, 8:29 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44415/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 8:29 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-983
> https://issues.apache.org/jira/browse/LENS-983
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changed all response type order.
> Added unit test to verify default type for session resource
>
>
> Diffs
> -----
>
> lens-ml-lib/src/main/java/org/apache/lens/ml/server/MLServiceResource.java 53bac7d
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 6e1a709
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java 6ee1e34
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 568b416
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java faaf172
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 424bd87
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java f38e70d
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java e54f0af
>
> Diff: https://reviews.apache.org/r/44415/diff/
>
>
> Testing
> -------
>
> INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.927s]
> [INFO] Lens .............................................. SUCCESS [3.689s]
> [INFO] Lens API .......................................... SUCCESS [27.397s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.915s]
> [INFO] Lens Cube ......................................... SUCCESS [11:09.116s]
> [INFO] Lens DB storage ................................... SUCCESS [20.530s]
> [INFO] Lens Query Library ................................ SUCCESS [16.930s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:04.066s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.248s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.084s]
> [INFO] Lens Server ....................................... SUCCESS [16:10.023s]
> [INFO] Lens client ....................................... SUCCESS [35.842s]
> [INFO] Lens CLI .......................................... SUCCESS [2:40.286s]
> [INFO] Lens Examples ..................................... SUCCESS [10.930s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.745s]
> [INFO] Lens Distribution ................................. SUCCESS [9.580s]
> [INFO] Lens ML Lib ....................................... FAILURE [40:03.571s]
> [INFO] Lens ML Ext Distribution .......................... SKIPPED
> [INFO] Lens Regression ................................... SKIPPED
> [INFO] Lens UI ........................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
>
> ML Lib failed because of https://issues.apache.org/jira/browse/LENS-982
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>