You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/12/25 11:15:16 UTC

[GitHub] [kyuubi] Yikf opened a new pull request, #4025: Tidy up the `Are you willing to submit PR` option in the issue template

Yikf opened a new pull request, #4025:
URL: https://github.com/apache/kyuubi/pull/4025

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   This pr aims to tidy up the `Are you willing to submit PR` option in the issue template.
     
   
   Currently, The `Are you willing to submit PR` option of some Apache kyuubi issue templates has three options as follow:
   - Yes. I can submit a PR independently to improve.
   - Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
   - No. I cannot submit a PR at this time.
   
   The intent of `Are you willing to submit PR` option is to confirm whether the questioner can submit PR at now, So two options are enough.
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [kyuubi] pan3793 commented on pull request #4025: Tidy up the `Are you willing to submit PR` option in the issue template

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4025:
URL: https://github.com/apache/kyuubi/pull/4025#issuecomment-1366318451

   Thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [kyuubi] Yikf commented on pull request #4025: Tidy up the `Are you willing to submit PR` option in the issue template

Posted by GitBox <gi...@apache.org>.
Yikf commented on PR #4025:
URL: https://github.com/apache/kyuubi/pull/4025#issuecomment-1365746634

   @pan3793 Is that OK?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [kyuubi] pan3793 closed pull request #4025: Tidy up the `Are you willing to submit PR` option in the issue template

Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #4025: Tidy up the `Are you willing to submit PR` option in the issue template
URL: https://github.com/apache/kyuubi/pull/4025


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org