You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yongjun Zhang (Code Review)" <ge...@cloudera.org> on 2019/02/07 02:41:00 UTC

[Impala-ASF-CR] IMPALA-7929: Allow null qualifier in THBaseFilter

Hello Paul Rogers, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12213

to look at the new patch set (#4).

Change subject: IMPALA-7929: Allow null qualifier in THBaseFilter
......................................................................

IMPALA-7929: Allow null qualifier in THBaseFilter

Impala query failed with "IntenalException: Required field 'qualifier'
was not present!" on table created via hive and mapped to HBase, because
the qualifier of the HBase key key column is null in the mapped table,
and Impala required non-null qualifier. The fix here is to relax this
requirement.

Test:
Added unit test.
Tested in real cluster.

Change-Id: I378c2249604481067b5b1c3a3bbb28c30ad4d751
---
M common/thrift/PlanNodes.thrift
M fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java
A testdata/workloads/functional-query/queries/QueryTest/hbase-col-filter.test
M tests/query_test/test_hbase_queries.py
4 files changed, 73 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/12213/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I378c2249604481067b5b1c3a3bbb28c30ad4d751
Gerrit-Change-Number: 12213
Gerrit-PatchSet: 4
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>